Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
6.5.0
-
Untriaged
-
Yes
Description
There is a significant increase in max (~9x) and average (~5x) memcached RSS. There are two tests:
Max. memcached RSS (MB). PathoGen Frozen 8B -> 8192B kv_fragmentation_pathoGen_frozen_memcached_rss_ares
4449 - http://perf.jenkins.couchbase.com/job/ares/10653/ - 9358
https://s3-us-west-2.amazonaws.com/perf-artifacts/jenkins-ares-10653/172.23.133.11.zip
https://s3-us-west-2.amazonaws.com/perf-artifacts/jenkins-ares-10653/172.23.133.12.zip
https://s3-us-west-2.amazonaws.com/perf-artifacts/jenkins-ares-10653/172.23.133.13.zip
https://s3-us-west-2.amazonaws.com/perf-artifacts/jenkins-ares-10653/172.23.133.14.zip
4448 - http://perf.jenkins.couchbase.com/job/ares/10668/ - 1097
https://s3-us-west-2.amazonaws.com/perf-artifacts/jenkins-ares-10668/172.23.133.11.zip
https://s3-us-west-2.amazonaws.com/perf-artifacts/jenkins-ares-10668/172.23.133.12.zip
https://s3-us-west-2.amazonaws.com/perf-artifacts/jenkins-ares-10668/172.23.133.13.zip
https://s3-us-west-2.amazonaws.com/perf-artifacts/jenkins-ares-10668/172.23.133.14.zip
The difference in kv_engine between the two builds is:
commit 510acc65d2ef846204f123a3feab64545233a616
Author: Trond Norbye <trond.norbye@gmail.com>
Date: Mon Sep 30 10:47:35 2019 +0200
Prepare Command Contexts for OoO [2/n]
When operating in OoO mode the underlying buffer for the
request may change the first time the command returns EWOULDBLOCK
as we'll try not to copy the buffer if we don't need our own
copy. This means that we can't keep pointers into the packet as
members in the command context (but fetch them from the cookie
every time).
Change-Id: Ice6b62a17609ffc119aa10d6016c980b8a301c2f
Reviewed-on: http://review.couchbase.org/115567
Tested-by: Trond Norbye <trond.norbye@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
commit 8cdb2cee3a4c9b599f58b2f0a615d7d7810bac3f
Author: Dave Rigby <daver@couchbase.com>
Date: Thu Sep 26 10:14:53 2019 +0100
Update uses of AtomicDuration to new template
platform's cb::AtomicDuration is now templated on the memory ordering
to use. Update the uses of AtomicDuration to use the correct template
syntax.
Change-Id: I00221d1acbea73f12a00d679e595f91739d998c0
Reviewed-on: http://review.couchbase.org/115416
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@couchbase.com>
and in platform:
commit f42ec1e99c185d1c242cb64bc8a38c1837fa9822
Author: Dave Rigby <daver@couchbase.com>
Date: Thu Sep 26 09:57:36 2019 +0100
Allow memory order of AtomicDuration to be specified
Change AtomicDuration to a templated class, templated on the memory
order to use. Defaults to the same memory order it previously used
(relaxed).
Change-Id: I00221d1acbea73f12a00d679e595f91739d998c0
Reviewed-on: http://review.couchbase.org/115575
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Ben Huddleston <ben.huddleston@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@couchbase.com>