Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-37009

DcpProducer::handleResponse() doesn't handle all valid error codes for Prepare, Commit and abort

    XMLWordPrintable

Details

    • Untriaged
    • Unknown
    • KV Sprint 2020-June

    Description

      Currently a DCP consumer can return the status codes bellow for a Prepare, Commit and abort. However, we don't handle of these status codes in an explicit manor and thus sometimes handle them incorrectly. This should be fixed to ensure we don't end up in situations like rebalance hang e.g. MB-36971 and MB-36794.
      (A status marked as [x] is a handled status code and [ ] for unhandled explicitly)
      DCP Prepare:

      • [ ] ENGINE_E2BIG
      • [ ] ENGINE_EWOULDBLOCK
        // Don’t think we would see from a consumer
      • [ ] ENGINE_LOCKED
      • [ ] ENGINE_SYNC_WRITE_IN_PROGRESS
      • [ ] ENGINE_KEY_EEXISTS
      • [ ] ENGINE_UNKNOWN_COLLECTION

      DCP Commit:
      See common

      DCP Abort:
      See common

      Common between all three ops:

      • [x] ENGINE_SUCCESS
      • [x] ENGINE_DISCONNECT
      • [x] ENGINE_EINVAL (disconnect for all ops)
      • [x] ENGINE_KEY_ENOENT (we don't disconnect for prepare and should only be ever sent by an active)
      • [ ] ENGINE_NOT_MY_VBUCKET
      • [ ] ENGINE_TMPFAIL
      • [ ] ENGINE_ENOMEM
      • [ ] ENGINE_ERANGE

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MB-39922 System Test: Rebalance failed due to DCP disconnect triggered by DCP_MUTATION - Data exists for key

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MB-39548 [Jepsen] KeyEexists received from DCP Consumer for DCP_COMMIT

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-39547 [Jepsen] KeyEexists received from DCP Consumer for DCP_PREPARE

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-39766 [Magma] Rebalance fails with "bad replicators after rebalance"

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-39809 [Magma]Rebalance exited with reason mover_crashed

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-40053 [BucketDurability]: KeyEexists received from DCP Consumer for DCP_COMMIT

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MB-39542 [Collections] - Rebalance in out + collections ttl data load fails in volume testing

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-39766 [Magma] Rebalance fails with "bad replicators after rebalance"

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-39809 [Magma]Rebalance exited with reason mover_crashed

          • Major - Major loss of function.
          • Closed
          For Gerrit Dashboard: MB-37009
          # Subject Branch Project Status CR V
          121189,14 MB-37009: Explicitly handle all DCP error codes from a Consumer mad-hatter kv_engine Status: MERGED +2 +1
          121428,6 MB-37009: Explicitly handle DCP error codes from a Consumer master kv_engine Status: ABANDONED -1 -1
          128733,2 Merge branch 'couchbase/mad-hatter' into 'couchbase/master' master kv_engine Status: ABANDONED 0 0
          128738,1 Merge branch 'couchbase/mad-hatter' into 'couchbase/master' master kv_engine Status: MERGED +2 +1
          129383,3 MB-37009: DcpProducer::handleResponce, don't disconnect on NotMyVbucket mad-hatter kv_engine Status: MERGED +2 +1
          129912,1 Merge branch mad-hatter into master master kv_engine Status: MERGED +2 +1
          129940,3 MB-37009: DcpProducer::handleResponce, don't disconnect on KeyEnoent mad-hatter kv_engine Status: MERGED +2 +1
          130046,3 MB-37009: DcpProducer::handleResponse, don't disconnect on KeyEexists mad-hatter kv_engine Status: MERGED +2 +1
          130303,1 Merge branch mad-hatter into master master kv_engine Status: MERGED +2 +1
          130410,1 Merge branch mad-hatter into master master kv_engine Status: MERGED +2 +1

          Activity

            People

              ashwin.govindarajulu Ashwin Govindarajulu
              richard.demellow Richard deMellow
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                PagerDuty