Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-37242

Ensure Backup does not generate DCP connection names that are no longer than allowed by memcached

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Done
    • 6.5.0
    • 7.0.0
    • tools
    • None

    Description

      DCP connections with long names break the STATS "dcp" command. (See MB-34280). cbbackupmgr should generate names that are no longer than the memcached limit.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            owend Daniel Owen created issue -
            owend Daniel Owen made changes -
            Field Original Value New Value
            Fix Version/s Cheshire-Cat [ 15915 ]
            owend Daniel Owen made changes -
            Link This issue blocks MB-34280 [ MB-34280 ]
            pvarley Patrick Varley made changes -
            Assignee Patrick Varley [ pvarley ] James Lee [ james.lee ]
            james.lee James Lee added a comment -

            All the DCP tools in the 'backup' repository rely on the following function to generate the DCP stream names:

            generateStreamName

            func generateStreamName() string {
            	startTime := time.Now()
            	return fmt.Sprintf("%s_%s_%d", version.Cmd, startTime.Format(time.RFC3339), startTime.UnixNano()%100000)
            }
            

            This will result in:
            1) 'cbbackupmgr' / 'cbexport'
            2) '2006-01-02T15:04:05Z07:00'
            3) Variable length integer with a max of 5 characters

            This will result in < 50 characters. Please note that for each DCP worker we postfix '_${WORKER_ID}'; even still, we should be under the 200 character limit.

            james.lee James Lee added a comment - All the DCP tools in the ' backup ' repository rely on the following function to generate the DCP stream names: generateStreamName func generateStreamName() string { startTime := time.Now() return fmt.Sprintf("%s_%s_%d", version.Cmd, startTime.Format(time.RFC3339), startTime.UnixNano()%100000) } This will result in: 1) ' cbbackupmgr ' / ' cbexport ' 2) ' 2006-01-02T15:04:05Z07:00 ' 3) Variable length integer with a max of 5 characters This will result in < 50 characters. Please note that for each DCP worker we postfix ' _${WORKER_ID }'; even still, we should be under the 200 character limit.
            james.lee James Lee made changes -
            Resolution Done [ 6 ]
            Status Open [ 1 ] Closed [ 6 ]
            lynn.straus Lynn Straus made changes -
            Fix Version/s 7.0.0 [ 17233 ]
            lynn.straus Lynn Straus made changes -
            Fix Version/s Cheshire-Cat [ 15915 ]

            People

              james.lee James Lee
              owend Daniel Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty