Details
-
Bug
-
Resolution: Fixed
-
Major
-
5.5.6, 6.0.3, 6.5.0
-
Untriaged
-
Unknown
Description
Our DCP code in 6.5.0 handles errors which are propagated up from the storage layer (instead of ignoring them, as we did in Alice). The issue here is that we are ignoring a large majority of the errors which ForestDB propagates; this is because we are using Go's defer statement.
db, err := fdb.Open("db.fdb")
|
if err != nil {
|
return err
|
}
|
defer db.Close() // <- Any error raised by "Close" will be explicitly ignored
|
This therefore means that even though we are handling errors in DCP, ForestDB isn't propagating the errors so they will never be handled.
Attachments
For Gerrit Dashboard: MB-37897 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
122257,1 | MB-37897 Return all FDB errors | master | backup | Status: ABANDONED | 0 | 0 |
122258,3 | MB-37897 Return all FDB errors | mad-hatter | backup | Status: MERGED | +2 | +1 |
122585,1 | Merge branch 'mad-hatter' into master | master | backup | Status: ABANDONED | -1 | +1 |
122595,2 | Merge branch 'mad-hatter' into master | master | backup | Status: MERGED | +2 | +1 |