Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-39114

VBucketFileWriter should close the chunk before closing the snapshot file

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.6.0
    • Fix Version/s: 6.6.0
    • Component/s: tools

      Description

      Currently the snapshot file is closed before closing this data chunk. This is invalid because in the case where the (most likely Rift) data writer is asynchronous (such as it is/will be for cloud) it's possible for the last persisted seqno to be ahead of the data that we have on disk.

      If we commit the data that we have on disk (which will be a blocking operation) then we persist the snapshot file we know that we have all the data.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-7.0.0-1970 contains backup commit 8a920eb with commit message:
          MB-39114 Persist the snapshot file after closing the chunk

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.0-1970 contains backup commit 8a920eb with commit message: MB-39114 Persist the snapshot file after closing the chunk
          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-6.6.0-7625 contains backup commit 8a920eb with commit message:
          MB-39114 Persist the snapshot file after closing the chunk

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-6.6.0-7625 contains backup commit 8a920eb with commit message: MB-39114 Persist the snapshot file after closing the chunk

            People

            Assignee:
            james.lee James Lee
            Reporter:
            james.lee James Lee
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty