Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-39697

cbbackupmgr read only restore can report a failure to remove lockfile

    XMLWordPrintable

Details

    Description

      If an error occurs during a read only restore, the error handler will attempt to remove the lockfile by calling the 'Unlock' function. Naturally this function will fail to remove the lockfile (if the bucket is actually in read-only mode) because we never created it.

      The cleanest way to solve this will be to have the lockfile implementation detect that we haven't actually run the 'Lock' function (and therefore the lockfile was not created) and return nil when the exit handler attempts to remove the lockfile. This avoiding leaking read only logic into the exit handler (which would ultimately end up producing a large (ish) code change due to 'exitIfError' being used all over the place).

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            james.lee James Lee
            james.lee James Lee
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty