[MB-43028] memOverheadChangedCallback heap-use-after-free during ~VBucket - Couchbase database

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 6.6.1
Fix Version/s: 6.6.1, 7.0.0
Component/s: couchbase-bucket
Labels:
- approved-for-6.6.1

Triage:
Triaged
Story Points:
1
Is this a Regression?:
Yes

Description

The memOverheadChangedCallback accesses the VBucket state.
During VBucket destruction the callback is triggered when destroying the CheckpointManager as this in turn destroys Checkpoint s, reducing overhead. The state is no longer valid at this point.

First seen in CV from merging patches introducing the memOverheadChangedCallback forward to master. Not previously identified on mad-hatter, possibly as a result of mad-hatter CV using an older clang.

http://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/7760/consoleFull#-130641249961882284-c5b1-40af-8076-4f8cb2d12fb1

Attachments

Issue Links

relates to

MB-42986 Intermittent TSan issue: heap-use-after-free ../kv_engine/engines/ep/src/ephemeral_bucket.cc:301 in operator() (3.3%)

Closed

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

For Gerrit Dashboard: MB-43028
#	Subject	Branch	Project	Status	CR	V
141020,9	Merge branch 'couchbase/mad-hatter' into master	master	kv_engine	Status: MERGED	+2	+1
141490,1	MB-43028: Reset memOverheadChangedCallback before VBucket destruction	master	kv_engine	Status: ABANDONED	-1	-1
141492,3	MB-43028: [1/2] Make overhead tracking safe at VBucket destruction	mad-hatter	kv_engine	Status: MERGED	+2	+1
141493,3	MB-43028: [2/2] Make overhead tracking safe at VBucket destruction	mad-hatter	kv_engine	Status: MERGED	+2	+1
141498,2	MB-43028: [1/2] Make overhead tracking safe at VBucket destruction	master	kv_engine	Status: MERGED	+2	+1
142432,1	Merge branch 'mad-hatter' into master	master	kv_engine	Status: MERGED	+2	+1

Activity

Ascending order - Click to sort in descending order

Couchbase Build Team added a comment - 04/Dec/20 10:08 AM

Build couchbase-server-6.6.1-9210 contains kv_engine commit d169730 with commit message:
~~MB-43028~~: [2/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 04/Dec/20 10:08 AM Build couchbase-server-6.6.1-9210 contains kv_engine commit d169730 with commit message: MB-43028 : [2/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 04/Dec/20 10:08 AM

Build couchbase-server-6.6.1-9210 contains kv_engine commit 6badce2 with commit message:
~~MB-43028~~: [1/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 04/Dec/20 10:08 AM Build couchbase-server-6.6.1-9210 contains kv_engine commit 6badce2 with commit message: MB-43028 : [1/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 04/Dec/20 1:05 PM

Build couchbase-server-7.0.0-3943 contains kv_engine commit e96a9f5 with commit message:
~~MB-43028~~: [1/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 04/Dec/20 1:05 PM Build couchbase-server-7.0.0-3943 contains kv_engine commit e96a9f5 with commit message: MB-43028 : [1/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 18/Dec/20 3:01 PM

Build couchbase-server-7.0.0-4084 contains kv_engine commit d169730 with commit message:
~~MB-43028~~: [2/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 18/Dec/20 3:01 PM Build couchbase-server-7.0.0-4084 contains kv_engine commit d169730 with commit message: MB-43028 : [2/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 18/Dec/20 3:01 PM

Build couchbase-server-7.0.0-4084 contains kv_engine commit 6badce2 with commit message:
~~MB-43028~~: [1/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 18/Dec/20 3:01 PM Build couchbase-server-7.0.0-4084 contains kv_engine commit 6badce2 with commit message: MB-43028 : [1/2] Make overhead tracking safe at VBucket destruction