[MB-43028] memOverheadChangedCallback heap-use-after-free during ~VBucket - Couchbase database

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 6.6.1
Fix Version/s: 6.6.1, 7.0.0
Component/s: couchbase-bucket
Labels:
- approved-for-6.6.1

Triage:
Triaged
Story Points:
1
Is this a Regression?:
Yes

Description

The memOverheadChangedCallback accesses the VBucket state.
During VBucket destruction the callback is triggered when destroying the CheckpointManager as this in turn destroys Checkpoint s, reducing overhead. The state is no longer valid at this point.

First seen in CV from merging patches introducing the memOverheadChangedCallback forward to master. Not previously identified on mad-hatter, possibly as a result of mad-hatter CV using an older clang.

http://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/7760/consoleFull#-130641249961882284-c5b1-40af-8076-4f8cb2d12fb1

Attachments

Issue Links

relates to

MB-42986 Intermittent TSan issue: heap-use-after-free ../kv_engine/engines/ep/src/ephemeral_bucket.cc:301 in operator() (3.3%)

Closed

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

No reviews matched the request. Check your Options in the drop-down menu of this sections header.

Activity

Ascending order - Click to sort in descending order

James Harrison created issue - 01/Dec/20 9:00 AM

James Harrison made changes - 01/Dec/20 9:00 AM

Field	Original Value	New Value
Link		This issue relates to ~~MB-42986~~ [ ~~MB-42986~~ ]

James Harrison made changes - 03/Dec/20 8:00 AM

Description

The {{memOverheadChangedCallback}} accesses the VBucket state.
During VBucket destruction the callback is triggered when destroying the {{CheckpointManager}} as this in turn destroys {{Checkpoint}}s, reducing overhead. The state is no longer valid at this point.

First seen in CV from merging patches introducing the {{memOverheadChangedCallback}} forward to master. Not previously identified on mad-hatter, possibly as a result of mad-hatter CV using an older clang.

http://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/7760/consoleFull#-130641249961882284-c5b1-40af-8076-4f8cb2d12fb1

The {{memOverheadChangedCallback}} accesses the VBucket state.
During VBucket destruction the callback is triggered when destroying the {{CheckpointManager}} as this in turn destroys {{Checkpoint}} s, reducing overhead. The state is no longer valid at this point.

First seen in CV from merging patches introducing the {{memOverheadChangedCallback}} forward to master. Not previously identified on mad-hatter, possibly as a result of mad-hatter CV using an older clang.

http://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/7760/consoleFull#-130641249961882284-c5b1-40af-8076-4f8cb2d12fb1

Daniel Owen made changes - 04/Dec/20 9:05 AM

Priority

Major [ 3 ]

Blocker [ 1 ]

Daniel Owen made changes - 04/Dec/20 9:05 AM

Fix Version/s		6.6.1 [ 17002 ]
Fix Version/s	6.6.2 [ 17103 ]

Daniel Owen made changes - 04/Dec/20 9:18 AM

Component/s

couchbase-bucket [ 10173 ]

Daniel Owen made changes - 04/Dec/20 9:18 AM

Labels

approved-for-6.6.1

Daniel Owen made changes - 04/Dec/20 9:18 AM

Is this a Regression?

Unknown [ 10452 ]

Yes [ 10450 ]

Daniel Owen made changes - 04/Dec/20 9:19 AM

Link

This issue relates to MB-40528 [ MB-40528 ]

Daniel Owen made changes - 04/Dec/20 9:19 AM

Link

This issue relates to MB-40528 [ MB-40528 ]

Daniel Owen made changes - 04/Dec/20 9:20 AM

Link

This issue blocks MB-40528 [ MB-40528 ]

Dave Rigby made changes - 04/Dec/20 9:36 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Daniel Owen made changes - 04/Dec/20 9:38 AM

Assignee	James Harrison [ james.harrison ]	Daniel Owen [ owend ]
Status	Resolved [ 5 ]	Closed [ 6 ]

Couchbase Build Team added a comment - 04/Dec/20 10:08 AM

Build couchbase-server-6.6.1-9210 contains kv_engine commit d169730 with commit message:
~~MB-43028~~: [2/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 04/Dec/20 10:08 AM Build couchbase-server-6.6.1-9210 contains kv_engine commit d169730 with commit message: MB-43028 : [2/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 04/Dec/20 10:08 AM

Build couchbase-server-6.6.1-9210 contains kv_engine commit 6badce2 with commit message:
~~MB-43028~~: [1/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 04/Dec/20 10:08 AM Build couchbase-server-6.6.1-9210 contains kv_engine commit 6badce2 with commit message: MB-43028 : [1/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 04/Dec/20 1:05 PM

Build couchbase-server-7.0.0-3943 contains kv_engine commit e96a9f5 with commit message:
~~MB-43028~~: [1/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 04/Dec/20 1:05 PM Build couchbase-server-7.0.0-3943 contains kv_engine commit e96a9f5 with commit message: MB-43028 : [1/2] Make overhead tracking safe at VBucket destruction

Wayne Siu made changes - 07/Dec/20 7:04 PM

Fix Version/s

Cheshire-Cat [ 15915 ]

Couchbase Build Team added a comment - 18/Dec/20 3:01 PM

Build couchbase-server-7.0.0-4084 contains kv_engine commit d169730 with commit message:
~~MB-43028~~: [2/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 18/Dec/20 3:01 PM Build couchbase-server-7.0.0-4084 contains kv_engine commit d169730 with commit message: MB-43028 : [2/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 18/Dec/20 3:01 PM

Build couchbase-server-7.0.0-4084 contains kv_engine commit 6badce2 with commit message:
~~MB-43028~~: [1/2] Make overhead tracking safe at VBucket destruction

Couchbase Build Team added a comment - 18/Dec/20 3:01 PM Build couchbase-server-7.0.0-4084 contains kv_engine commit 6badce2 with commit message: MB-43028 : [1/2] Make overhead tracking safe at VBucket destruction

Lynn Straus made changes - 17/Jun/21 3:39 PM

Fix Version/s

7.0.0 [ 17233 ]

Lynn Straus made changes - 17/Jun/21 3:45 PM

Fix Version/s

Cheshire-Cat [ 15915 ]