Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
Cheshire-Cat, 6.6.1
-
Untriaged
-
1
-
Yes
Description
The LIKE operator caches the compiled regular expression in expression tree and then continues to use it even if the input argument has changed. This affects PREPARED statements.
Attachments
Issue Links
- is caused by
-
-
- Closed
-
| For Gerrit Dashboard: MB-44354 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 146181,10 | MB-44354 note LIKE pattern and validate it is unchanged before using cached compiled regular expression | mad-hatter | query | Status: MERGED | +2 | +1 |
| 146199,8 | MB-44354 note LIKE pattern and validate it is unchanged before using cached compiled regular expression | master | query | Status: MERGED | +2 | +1 |
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description | The LIKE operator caches the compiled regular expression and then blindly uses it even if the input argument has changed. This affects PREPARED statements. | The LIKE operator caches the compiled regular expression in expression tree and then blindly uses it even if the input argument has changed. This affects PREPARED. |
| Affects Version/s | 6.6.1 [ 17002 ] | |
| Affects Version/s | Cheshire-Cat [ 15915 ] |
| Fix Version/s | Cheshire-Cat [ 15915 ] | |
| Fix Version/s | 6.6.2 [ 17103 ] |
| Component/s | query [ 10718 ] |
| Is this a Regression? | Unknown [ 10452 ] | Yes [ 10450 ] |
| Link | This issue blocks CBSE-9655 [ CBSE-9655 ] |
| Labels | 6.6.2-candidate |
| Link | This issue blocks CBSE-9666 [ CBSE-9666 ] |
| Link | This issue blocks MB-43310 [ MB-43310 ] |
| Labels | 6.6.2-candidate | approved-for-6.6.2 |
| Description | The LIKE operator caches the compiled regular expression in expression tree and then blindly uses it even if the input argument has changed. This affects PREPARED. | The LIKE operator caches the compiled regular expression in expression tree and then blindly uses it even if the input argument has changed. This affects PREPARED statements. |
Build couchbase-server-6.6.2-9515 contains query commit 87f8726 with commit message:
MB-44354 note LIKE pattern and validate it is unchanged before using cached compiled regular expression
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Assignee | Donald Haggart [ JIRAUSER25287 ] | Pierre Regazzoni [ JIRAUSER25157 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
Verified on build 6.6.2-9515 and 7.0.0-4502.
p2 is defined as: "prepare p2 as select airportname from `travel-sample` where type = \"airport\" and city like $ville;"
cbq> \set -$ville "Lyon"; |
cbq> execute p2;
|
{
|
"requestID": "e22a93ec-ae63-4e5d-8c63-80a9c0333529", |
"signature": { |
"airportname": "json" |
},
|
"results": [ |
{
|
"airportname": "Lyon Part-Dieu Railway" |
},
|
{
|
"airportname": "Saint Exupery" |
},
|
{
|
"airportname": "Bron" |
}
|
],
|
"status": "success", |
"metrics": { |
"elapsedTime": "6.883394ms", |
"executionTime": "6.677766ms", |
"resultCount": 3, |
"resultSize": 138 |
}
|
}
|
cbq> \set -$ville "Paris"; |
cbq> execute p2;
|
{
|
"requestID": "972f5c79-db9b-4b83-aa84-732ff64b4387", |
"signature": { |
"airportname": "json" |
},
|
"results": [ |
{
|
"airportname": "Orly" |
},
|
{
|
"airportname": "Gare Montparnasse" |
},
|
{
|
"airportname": "La Defense Heliport" |
},
|
{
|
"airportname": "Gare de Lyon" |
},
|
{
|
"airportname": "All Airports" |
},
|
{
|
"airportname": "Le Bourget" |
},
|
{
|
"airportname": "Gare du Nord" |
},
|
{
|
"airportname": "Gare de LEst" |
},
|
{
|
"airportname": "Charles De Gaulle" |
}
|
],
|
"status": "success", |
"metrics": { |
"elapsedTime": "65.257726ms", |
"executionTime": "64.986389ms", |
"resultCount": 9, |
"resultSize": 412 |
}
|
}
|
cbq>
|
I also could repro issue on 6.6.2-9514:
cbq> \set -$ville "Lyon"; |
cbq> execute p2;
|
{
|
"requestID": "53bb8af6-5852-4923-b555-d8431619f602", |
"signature": { |
"airportname": "json" |
},
|
"results": [ |
{
|
"airportname": "Bron" |
},
|
{
|
"airportname": "Saint Exupery" |
},
|
{
|
"airportname": "Lyon Part-Dieu Railway" |
}
|
],
|
"status": "success", |
"metrics": { |
"elapsedTime": "7.043359ms", |
"executionTime": "6.681565ms", |
"resultCount": 3, |
"resultSize": 138 |
}
|
}
|
cbq> \set -$ville "Paris"; |
cbq> execute p2;
|
{
|
"requestID": "b252cfb3-e93c-4b36-a747-98bc7fcc6671", |
"signature": { |
"airportname": "json" |
},
|
"results": [ |
],
|
"status": "success", |
"metrics": { |
"elapsedTime": "53.22673ms", |
"executionTime": "53.041761ms", |
"resultCount": 0, |
"resultSize": 0 |
}
|
}
|
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Link | This issue blocks MB-44623 [ MB-44623 ] |
| Link | This issue relates to MB-45345 [ MB-45345 ] |
| Labels | approved-for-6.6.2 | approved-for-6.6.2 releasenote |
Donald Haggart / Pierre Regazzoni We would like this to be in the Release Notes for 6.6.2, can you please provide the summary?
Chris Malarky, my summary would be:
LIKE patterns are compiled and cached to avoid recompiling unnecessarily. This fix addresses a problem where a previously cached compiled pattern that did not match the active pattern was used by prepared statements.
Or alternatively:
This fix addresses a bug where prepared statements failed to observe changes to LIKE predicate patterns.
| Fix Version/s | 7.0.0 [ 17233 ] |
| Fix Version/s | Cheshire-Cat [ 15915 ] |
| Description | The LIKE operator caches the compiled regular expression in expression tree and then blindly uses it even if the input argument has changed. This affects PREPARED statements. | The LIKE operator caches the compiled regular expression in expression tree and then continues to use it even if the input argument has changed. This affects PREPARED statements. |
| Labels | approved-for-6.6.2 releasenote | approved-for-6.6.2 needs-automation releasenote |
Build couchbase-server-7.0.0-4483 contains query commit 1aaca7b with commit message:
MB-44354note LIKE pattern and validate it is unchanged before using cached compiled regular expression