Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-4564

Don't delete database files when node leaves cluster.

    Details

      Description

      A recent bug brought up a concern around the process of deleting the on-disk data files when a node is failed over or removed from the cluster.

      I think it would be a better approach to preserve this data in the event that it is needed. Perhaps moving them out of the way and messaging to the user that they can clean them up manually when needed.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        alkondratenko Aleksey Kondratenko (Inactive) added a comment -

        how you want user to be notifed? We can use user-visible log message or we can have alert-like thing.

        Show
        alkondratenko Aleksey Kondratenko (Inactive) added a comment - how you want user to be notifed? We can use user-visible log message or we can have alert-like thing.
        Hide
        perry Perry Krug added a comment -

        I'd specifically like something that makes the user confirm that they understand that proceeding with whatever action will result in the deleting of files they may want to save. A log message after the fact doesn't give them the ability to recover that data.

        Show
        perry Perry Krug added a comment - I'd specifically like something that makes the user confirm that they understand that proceeding with whatever action will result in the deleting of files they may want to save. A log message after the fact doesn't give them the ability to recover that data.
        Hide
        steve Steve Yen added a comment -

        alk predicts this evening ETA

        Show
        steve Steve Yen added a comment - alk predicts this evening ETA
        Show
        alkondratenko Aleksey Kondratenko (Inactive) added a comment - http://review.couchbase.org/14628
        Hide
        thuan Thuan Nguyen added a comment -

        Integrated in github-ns-server-2-0 #333 (See http://qa.hq.northscale.net/job/github-ns-server-2-0/333/)
        MB-4564 Don't delete database files when node leaves cluster. (Revision ac961c9839396f64ef6c0ef56e5f298095a0da63)

        Result = SUCCESS
        Aliaksey Kandratsenka :
        Files :

        • src/ns_memcached.erl
        • src/ns_cluster.erl
        • src/menelaus_web_buckets.erl
        • src/menelaus_web.erl
        • src/ns_storage_conf.erl
        • src/ns_rebalancer.erl
        Show
        thuan Thuan Nguyen added a comment - Integrated in github-ns-server-2-0 #333 (See http://qa.hq.northscale.net/job/github-ns-server-2-0/333/ ) MB-4564 Don't delete database files when node leaves cluster. (Revision ac961c9839396f64ef6c0ef56e5f298095a0da63) Result = SUCCESS Aliaksey Kandratsenka : Files : src/ns_memcached.erl src/ns_cluster.erl src/menelaus_web_buckets.erl src/menelaus_web.erl src/ns_storage_conf.erl src/ns_rebalancer.erl

          People

          • Assignee:
            Aliaksey Artamonau Aliaksey Artamonau
            Reporter:
            perry Perry Krug
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes