Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-46878

Where possible 'cbbackupmgr' should avoid the truncate/overwrite pattern

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Done
    • 7.1.0
    • 7.1.0
    • tools
    • None
    • 1

    Description

      What's the issue?
      When updating files, we quite often use utilities such as `os.WriteFile`, internally this will open the file with the 'O_TRUNC' flag, then write the given data. This opens ourselves to issues where truncation succeeds, but the write fails (meaning it's possible to end up with partial/empty files).

      What's the fix?
      For "mission critical" files, we should use atomic operations, for example when updating the plan.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MB-48485 [CBM] Failed to resume backup with error ' (bucket0) (vb 867) Received an unexpected error from the sink callback, beginning teardown'

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. DOC-8642 [CBM] Add documentation around 'hide dot files' on Samba

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. MB-45622 [CBM] Improve resilience to power outage/kill -9 scenarios

          • Major - Major loss of function.
          • Open
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Ascending order - Click to sort in descending order
            james.lee James Lee created issue -
            james.lee James Lee made changes -
            Field Original Value New Value
            Link This issue relates to DOC-8642 [ DOC-8642 ]
            james.lee James Lee made changes -
            Link This issue relates to MB-48485 [ MB-48485 ]
            james.lee James Lee made changes -
            Link This issue relates to MB-45622 [ MB-45622 ]
            james.lee James Lee made changes -
            Issue Type Bug [ 1 ] Task [ 3 ]
            james.lee James Lee made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            james.lee James Lee made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            james.lee James Lee made changes -
            Resolution Done [ 6 ]
            Status Reopened [ 4 ] Closed [ 6 ]

            People

              james.lee James Lee
              james.lee James Lee
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty