Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-46942

[Refactor] Remove various clj-ssh related exception handling

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Major
    • None
    • None
    • Jepsen
    • None

    Description

      The updated Jepsen library relies on scp to upload and download files.

      See: https://github.com/jepsen-io/jepsen/blob/6ccf9ce00835faebbea9eb55409a52da8f60ae83/jepsen/src/jepsen/control/scp.clj#L111

      This means we can most likely get rid of the alter-var-root of jepsen.control/download that catches the exceptions thrown by clj-ssh.

      See: https://github.com/couchbaselabs/jepsen.couchbase/blob/1bab48a83361d6ca69e8cf7ba278df1b2617f327/src/couchbase/core.clj#L179

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            asad.zaidi Asad Zaidi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty