Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-47511

Make query service topology aware from 7.1.0

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Neo
    • Neo
    • ns_server

    Description

      As per our discussion on July 19-2021, for the graceful exit of query service, we need query to be added as a topology-aware service.

      This is needed for cluster-aware rebalance feature for query, wherein if a node with query service is rebalanced, we want to 

      1.Complete all queries in progress (instead of shutting down immediately)

      2.Wait for the in-flight transactions to complete

      3.Not accept any new requests

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            meni.hillel Meni Hillel added a comment -

            Kamini Jagtiani Do you need anything else at this point, other than the instructions already provided to Donald to enable topology awareness for Query? Once Donald Haggart confirms things works, I am assuming we may need a bit more work to figure out upgrade/migration. We'll need to smooth transition from pre-7.1 to 7.1 so Query will need to be aware of compat mode and only once cluster is capable operating in 7.1 mode, you should activate topology aware capabilities. Till that point, query must operate in the current mode.

            meni.hillel Meni Hillel added a comment - Kamini Jagtiani Do you need anything else at this point, other than the instructions already provided to Donald to enable topology awareness for Query? Once Donald Haggart confirms things works, I am assuming we may need a bit more work to figure out upgrade/migration. We'll need to smooth transition from pre-7.1 to 7.1 so Query will need to be aware of compat mode and only once cluster is capable operating in 7.1 mode, you should activate topology aware capabilities. Till that point, query must operate in the current mode.

            Meni Hillel,

            Right now, I just created this improvement - for tracking changes needed to ns_server.

            ceej confirmed that Donald Haggart was doing the right thing and the issue he was seeing with the toy build is a product issue.

            For now, Donald Haggart will try out the fix, Dave had pointed us to. Once query starts getting notified of topology changes, we can start making the remaining query changes.
            ns_server can then merge the topology changes -in co-ordination with query, at a later date.

            kamini.jagtiani Kamini Jagtiani added a comment - Meni Hillel , Right now, I just created this improvement - for tracking changes needed to ns_server. ceej confirmed that Donald Haggart  was doing the right thing and the issue he was seeing with the toy build is a product issue. For now, Donald Haggart  will try out the fix, Dave had pointed us to. Once query starts getting notified of topology changes, we can start making the remaining query changes. ns_server can then merge the topology changes -in co-ordination with query, at a later date.
            meni.hillel Meni Hillel added a comment -

            Please assign to me once you've completed query side work

            meni.hillel Meni Hillel added a comment - Please assign to me once you've completed query side work

            The query defect for this is:MB-40533

            This bug is for ns_server bit.

            kamini.jagtiani Kamini Jagtiani added a comment - The query defect for this is: MB-40533 This bug is for ns_server bit.

            Meni Hillel, I'm assigning this back to you as I've merged the Query service changes (MB-40533) and we're thus now ready for the ns_server side change.   (The ns_server change I made in the toy build I developed against can be found here http://review.couchbase.org/c/ns_server/+/157669)

            Donald.haggart Donald Haggart added a comment - Meni Hillel , I'm assigning this back to you as I've merged the Query service changes ( MB-40533 ) and we're thus now ready for the ns_server side change.   (The ns_server change I made in the toy build I developed against can be found here http://review.couchbase.org/c/ns_server/+/157669 )

            Build couchbase-server-7.1.0-1139 contains ns_server commit b91ca38 with commit message:
            MB-47511 make query service topology aware

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1139 contains ns_server commit b91ca38 with commit message: MB-47511 make query service topology aware

            People

              mihir.kamdar Mihir Kamdar
              kamini.jagtiani Kamini Jagtiani
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty