Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-47685

Plasma Stats Compact Counter not updated on CompactFullMarshal

    XMLWordPrintable

Details

    • Untriaged
    • 1
    • Unknown

    Description

      On Page Marshal, a page can get compacted if CompactFullMarshal is enabled. We are not updating the compacts counter in code paths involving LSSCleaner, Persist after a page is Marshalled.

       

      // Compact the page if going through full marshal
      func (pg *page) compactFullMarshal(maxSegments int) (bool, int, int) {
      if pg.ctx.CompactFullMarshal &&
      pg.head != nil &&
      pg.head.GetOp() != opBasePage &&
      pg.head.GetOp() != opPageRemoveDelta &&
      pg.head.GetOp() != opMetaDelta {
      // full marshal required?
      if_, fInfo := pg.findFlushInfo(); fInfo != nil {
      if fInfo.NumSegments > maxSegments {
      dataSz, hdrSz := pg.Compact()
      returntrue, dataSz, hdrSz
      }
      }
      }
      returnfalse, 0, 0
      }

       

      Attachments

        Issue Links

          For Gerrit Dashboard: MB-47685
          # Subject Branch Project Status CR V

          Activity

            Build couchbase-server-7.1.0-1563 contains plasma commit 3c928a7 with commit message:
            MB-47685: Update compacts on page NoFullMarshal

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1563 contains plasma commit 3c928a7 with commit message: MB-47685 : Update compacts on page NoFullMarshal

            Build couchbase-server-7.1.0-1138 contains plasma commit 5f2c549 with commit message:
            MB-47685: Fix compact count due to compactFullMarshal

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1138 contains plasma commit 5f2c549 with commit message: MB-47685 : Fix compact count due to compactFullMarshal

            People

              saptarshi.sen Saptarshi Sen
              saptarshi.sen Saptarshi Sen
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty