Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
7.1.0
-
Untriaged
-
1
-
Yes
Description
We see EE compact time elapsed increased from 30 seconds to 80 seconds in 7.1.
http://showfast.sc.couchbase.com/#/timeline/Linux/tools/compact/SQLite
Build: 7.1.0-1085
Job: http://perf.jenkins.couchbase.com/job/leto/19978/
Logs:
https://s3-us-west-2.amazonaws.com/perf-artifacts/jenkins-leto-19978/tools.zip
Attachments
Issue Links
- is caused by
-
MB-46367 VBucketBackupWriter compaction should use a hofp worker pool
-
- Closed
-
Hi Bo-Chun Wang,
Thanks for raising this, I hadn't noticed the regression until now. We haven't changed much around compaction (which is lucky) because it made finding this slightly easier. The only change that's been made to compaction was this one.
This change switched over from using a bespoke worker pool, to a generic one which I added to out tools common library. In this change there's a somewhat subtle bug; we were never actually using the constructed worker pool i.e. compaction was always using a single thread.
This wasn't picked up by the compiler because the worker pool itself was still referenced (to begin/block on teardown). I'll get a patch up to fix this issue (it's worth noting that this is a level above SQLite, so this will affect all storage types).
Thanks,
James