Description
Currently RocksDB is included in builds unless you set the variable CB_PRODUCTION_BUILD. This flag is set by the production build jobs and nowhere else, so all developer builds and toy builds will include RocksDB.
This proved problematic when a separate bug caused the CB_PRODUCTION_BUILD flag to get lost in the builds. It also means that toy and developer builds are qualitatively different to production builds, which could lead to unexpected differences in testing - this is probably not a problem, but still feels like an unnecessary risk.
Per Wayne Siu, the builds should make inclusion of RocksDB opt-in via a specific CMake flag / environment variable, such as CB_USE_ROCKSDB.
Attachments
Issue Links
- mentioned in
-
Page Loading...