Details
-
Bug
-
Resolution: Fixed
-
Major
-
Cheshire-Cat
-
Untriaged
-
1
-
Unknown
Description
On Page Marshal, a page can get compacted if CompactFullMarshal is enabled. We are not updating the compacts counter in code paths involving LSSCleaner, Persist after a page is Marshalled.
// Compact the page if going through full marshal
func (pg *page) compactFullMarshal(maxSegments int) (bool, int, int) {
if pg.ctx.CompactFullMarshal &&
pg.head != nil &&
pg.head.GetOp() != opBasePage &&
pg.head.GetOp() != opPageRemoveDelta &&
pg.head.GetOp() != opMetaDelta {
// full marshal required?
if_, fInfo := pg.findFlushInfo(); fInfo != nil {
if fInfo.NumSegments > maxSegments {
dataSz, hdrSz := pg.Compact()
returntrue, dataSz, hdrSz
}
}
}
returnfalse, 0, 0
}
Attachments
Issue Links
- is a backport of
-
MB-47685 Plasma Stats Compact Counter not updated on CompactFullMarshal
- Closed