Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
Cheshire-Cat
-
Untriaged
-
1
-
Unknown
Description
On Page Marshal, a page can get compacted if CompactFullMarshal is enabled. We are not updating the compacts counter in code paths involving LSSCleaner, Persist after a page is Marshalled.
// Compact the page if going through full marshal
func (pg *page) compactFullMarshal(maxSegments int) (bool, int, int) {
if pg.ctx.CompactFullMarshal &&
pg.head != nil &&
pg.head.GetOp() != opBasePage &&
pg.head.GetOp() != opPageRemoveDelta &&
pg.head.GetOp() != opMetaDelta {
// full marshal required?
if_, fInfo := pg.findFlushInfo(); fInfo != nil {
if fInfo.NumSegments > maxSegments {
dataSz, hdrSz := pg.Compact()
returntrue, dataSz, hdrSz
}
}
}
returnfalse, 0, 0
}
Attachments
Issue Links
- is a backport of
-
MB-47685 Plasma Stats Compact Counter not updated on CompactFullMarshal
-
- Closed
-
Activity
Fix Version/s | 7.0.2 [ 18012 ] | |
Fix Version/s | Neo [ 17615 ] |
Summary |
[BP 7.0.2 |
[BP 7.0.2] - Plasma Stats Compact Counter not updated on CompactFullMarshal |
Affects Version/s | Cheshire-Cat [ 15915 ] |
Link | This issue blocks MB-46308 [ MB-46308 ] |
Labels | plasma | approved-for-7.0.2 plasma |
Resolution | Fixed [ 1 ] | |
Status | Open [ 1 ] | Resolved [ 5 ] |
Labels | approved-for-7.0.2 plasma | approved-for-7.0.2 plasma request-dev-verify |
Status | Resolved [ 5 ] | Closed [ 6 ] |
Wayne Siu Please approve this fix for 7.0.2. This fixes a stats that was missed in one case. This will help in avoiding inconsistent stats. The fix is straightforward. Return value of a function changed causing a number of files to be updated but the impact is minimal.