Details
-
Bug
-
Resolution: Fixed
-
Major
-
7.1.0
-
None
-
Triaged
-
1
-
No
-
KV-Engine Sprint 2021 August, KV-Engine-Sept-21
Description
RollbackResult MagmaKVStore::rollback(Vbid vbid,
|
uint64_t rollbackSeqno,
|
std::unique_ptr<RollbackCB> callback) {
|
...
|
auto keyCallback =
|
[this, cb = callback.get(), vbid](const Slice& keySlice,
|
const uint64_t seqno,
|
const Slice& metaSlice) {
|
auto diskKey = makeDiskDocKey(keySlice);
|
auto docKey = diskKey.getDocKey();
|
if (docKey.isInSystemCollection()) {
|
return;
|
}
|
...
|
|
cb->callback(rv);
|
};
|
...
|
}
|
is skipping system events before invoking the RollbackCB. The EPDiskRollbackCB already skips these items and we shouldn't assume they need skipping in the KVStore. Need to fix this to test the callback invocations properly with NexusKVStore.
Attachments
Issue Links
- relates to
-
MB-47604 NexusKVStore implementation
- Closed