Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-48324

N1QL version needs update

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 7.0.2
    • 7.0.2
    • query
    • Untriaged
    • 1
    • Unknown

    Description

      Recently N1QL minor version is started updating (MB-47186).

      7.0.2 point to 7.0.1
      https://github.com/couchbase/query/blob/cheshire-cat/util/version.go

      If there is better way we should populate from manifest to avoid maintenance.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          I believe you could handle this today by adding this to your LDFLAGS argument to GoModBuild() :

           -X util.VERSION=${PRODUCT_VERSION}

          Two issues: first you might need to change VERSION in util.go to be non-const. Second, PRODUCT_VERSION is actually eg. "7.0.2-1234" including the build number, so if you really only want the VERSION part you'd need to do a quick bit of CMake string manipulation.

          It seems like this might be generally useful, though, so I'd suggest that for 7.0.2 you just change version.go by hand, and for Neo we'll implement something that can set VERSION and BLD_NUM as global variables for all Go programs.

          ceej Chris Hillery added a comment - I believe you could handle this today by adding this to your LDFLAGS argument to GoModBuild() : -X util.VERSION=${PRODUCT_VERSION} Two issues: first you might need to change VERSION in util.go to be non-const. Second, PRODUCT_VERSION is actually eg. "7.0.2-1234" including the build number, so if you really only want the VERSION part you'd need to do a quick bit of CMake string manipulation. It seems like this might be generally useful, though, so I'd suggest that for 7.0.2 you just change version.go by hand, and for Neo we'll implement something that can set VERSION and BLD_NUM as global variables for all Go programs.

          Build couchbase-server-7.0.2-6655 contains query commit e33abd9 with commit message:
          MB-48324 Update N1QL version

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.2-6655 contains query commit e33abd9 with commit message: MB-48324 Update N1QL version

          Build couchbase-server-7.1.0-1265 contains query commit e247f33 with commit message:
          MB-48324 Automate N1QL version update

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1265 contains query commit e247f33 with commit message: MB-48324 Automate N1QL version update

          People

            Donald.haggart Donald Haggart
            Sitaram.Vemulapalli Sitaram Vemulapalli
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty