Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-48473

MagmaKVStore incrementing purgeSeqno when purging complete prepares and dropping collection items during implicit compaction

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 7.1.0
    • 7.1.0
    • couchbase-bucket
    • None
    • Triaged
    • 1
    • Yes
    • KV-Engine-Sept-21

    Description

      We don't do this for couchstore as complete prepares do not need to be sent/received. This was not spotted in review of this change - http://review.couchbase.org/c/kv_engine/+/160292. In addition we are currently moving the purge seqno for collection items purged in implicit compactions which is not necessary either.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Build couchbase-server-7.1.0-1330 contains kv_engine commit fe421ec with commit message:
            MB-48473: Don't move purge seqno for implicitly purged prepares

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1330 contains kv_engine commit fe421ec with commit message: MB-48473 : Don't move purge seqno for implicitly purged prepares

            Build couchbase-server-7.1.0-1330 contains kv_engine commit ed469b1 with commit message:
            MB-48473: Allow expansion of implicit compaction test

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1330 contains kv_engine commit ed469b1 with commit message: MB-48473 : Allow expansion of implicit compaction test

            Build couchbase-server-7.1.0-1349 contains kv_engine commit 0e49b51 with commit message:
            MB-48473: Don't move purge seqno for implictly purged logical deletes

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1349 contains kv_engine commit 0e49b51 with commit message: MB-48473 : Don't move purge seqno for implictly purged logical deletes

            Build couchbase-server-7.1.0-1349 contains kv_engine commit 7421ade with commit message:
            MB-48473: Make implicit compact test less racy

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1349 contains kv_engine commit 7421ade with commit message: MB-48473 : Make implicit compact test less racy

            People

              ben.huddleston Ben Huddleston
              ben.huddleston Ben Huddleston
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty