Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-49259

PCH setup is incorrect (refuse to use PCH due to incorrect nlohmann json flags)

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • Morpheus
    • 7.1.0
    • memcached
    • None
    • Untriaged
    • 1
    • Unknown

    Description

      When building on Ubuntu I see the following warning:

      [1/2] Building CXX object kv_engine/tests/engine_error/CMakeFiles/memcached-engine-error-test.dir/engine_error_test.cc.o
      		 
          cc1plus: warning: /home/trond/compile/trunk/cmake-build-debug/kv_engine/CMakeFiles/kv_pch.dir/cmake_pch.hxx.gch: not used because 
      `JSON_USE_IMPLICIT_CONVERSIONS' not defined [-Winvalid-pch]
      		 
          [2/2] Linking CXX executable kv_engine/memcached-engine-error-test

      According to a comment on http://review.couchbase.org/c/kv_engine/+/164149/1/engines/ep/CMakeLists.txt#250 this is caused by an incorrect PCH setup.

      It may be reproduced in the docker image: couchbasebuild/server-ubuntu18-build:latest

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            owend Daniel Owen
            trond Trond Norbye
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty