Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-49729

DCP system events should be considered encapsulated within OSO snapshots

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 7.0.2
    • 7.1.0
    • analytics
    • Untriaged
    • 1
    • Unknown
    • CX Sprint 274, CX Sprint 277

    Description

      The Collections spec states:

      During receipt of the OSO snapshot (i.e. begin received, but not the end) keep track of the greatest seqno received, consider this X.
      X = max(X, received message.seqno).
      The client must do this tracking for all DCP mutation, deletion, expiration and system events. If the client enabled synchronous replication, they would also need to include DCP prepare and abort messages.

      Analytics DCP client does not consider system events to be within the OSO snapshot tracking, this should be fixed in Neo.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            michael.blow Michael Blow created issue -
            michael.blow Michael Blow made changes -
            Field Original Value New Value
            Summary All DCP events should be considered encapsulated within OSO snapshots DCP system events should be considered encapsulated within OSO snapshots
            till Till Westmann made changes -
            Rank Ranked higher
            till Till Westmann made changes -
            Assignee Till Westmann [ till ] Michael Blow [ michael.blow ]
            till Till Westmann made changes -
            Labels triaged
            till Till Westmann made changes -
            Rank Ranked higher
            till Till Westmann made changes -
            Rank Ranked higher
            till Till Westmann made changes -
            Rank Ranked higher
            michael.blow Michael Blow made changes -
            Sprint CX Sprint 274 [ 1911 ]
            michael.blow Michael Blow made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            michael.blow Michael Blow made changes -
            Link This issue relates to MB-49779 [ MB-49779 ]
            michael.blow Michael Blow made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]

            Build couchbase-server-7.1.0-1901 contains analytics-dcp-client commit 13044bd with commit message:
            MB-49729: seqno advancements should be fully encapsulated within oso

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1901 contains analytics-dcp-client commit 13044bd with commit message: MB-49729 : seqno advancements should be fully encapsulated within oso

            Build couchbase-server-7.1.0-1901 contains cbas-core commit 378d826 with commit message:
            MB-49729: enable receipt of SEQNO_ADVANCED within an OSO snapshot

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1901 contains cbas-core commit 378d826 with commit message: MB-49729 : enable receipt of SEQNO_ADVANCED within an OSO snapshot
            michael.blow Michael Blow added a comment -

            On review of the ingestion pipeline, I see an issue with the current implementation that prevents correct handling of SEQNO_ADVANCED within an oso snapshot; reopening

            michael.blow Michael Blow added a comment - On review of the ingestion pipeline, I see an issue with the current implementation that prevents correct handling of SEQNO_ADVANCED within an oso snapshot; reopening
            michael.blow Michael Blow made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            michael.blow Michael Blow made changes -
            Sprint CX Sprint 274 [ 1911 ] CX Sprint 274, CX Sprint 277 [ 1911, 1953 ]

            Build couchbase-server-7.1.0-2015 contains cbas-core commit 639f49f with commit message:
            Revert "MB-49729: enable receipt of SEQNO_ADVANCED within an OSO snapshot"

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-2015 contains cbas-core commit 639f49f with commit message: Revert " MB-49729 : enable receipt of SEQNO_ADVANCED within an OSO snapshot"
            michael.blow Michael Blow made changes -
            Status Reopened [ 4 ] In Progress [ 3 ]

            Build couchbase-server-7.1.0-2026 contains cbas-core commit 1fc5fa5 with commit message:
            MB-49729: handle seqno advancements within an OSO snapshot

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-2026 contains cbas-core commit 1fc5fa5 with commit message: MB-49729 : handle seqno advancements within an OSO snapshot
            michael.blow Michael Blow made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            umang.agrawal Umang made changes -
            Labels triaged request-dev-verify triaged
            till Till Westmann made changes -
            Assignee Michael Blow [ michael.blow ] Murtadha Hubail [ murtadha.hubail ]
            murtadha.hubail Murtadha Hubail made changes -
            Labels request-dev-verify triaged triaged

            Verified as part of code review.

            murtadha.hubail Murtadha Hubail added a comment - Verified as part of code review.
            murtadha.hubail Murtadha Hubail made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            michael.blow Michael Blow made changes -
            Labels triaged candidate-for-7.0.4 triaged
            till Till Westmann added a comment - - edited

            Potentially causes skipped data on ingestion recovery - leading to wrong query results.

            till Till Westmann added a comment - - edited Potentially causes skipped data on ingestion recovery - leading to wrong query results.
            till Till Westmann made changes -
            Link This issue is cloned by MB-51695 [ MB-51695 ]
            till Till Westmann made changes -
            Labels candidate-for-7.0.4 triaged triaged

            People

              murtadha.hubail Murtadha Hubail
              michael.blow Michael Blow
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  PagerDuty