Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-49837

[CBM] [OBJSTORE] Backup resume validation is overly aggressive

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 7.1.0
    • 7.1.0
    • tools
    • None
    • Untriaged
    • 1
    • No
    • Tools 2021 Dec, Tools 2022-Jan

    Description

      What's the issue?
      When resuming a cloud backup, we validate that the resume can be continued; this check is slightly too aggressive at the moment.

      1) Fetch the known parts from the upload manifest
      2) Fetch the remote parts (those that the object store knows about)
      3) Validate that all the local parts, exist in the remote

      We currently allow the remote parts to contain more elements than the local parts (which is valid i.e. manifest persist fails) however, this breaks the validation logic.

      1) Sort the local parts by id
      2) Sort the remote parts by id
      3) Compare all the parts

      If remote has more elements, it's unlikely to pass, even though the resume may actually be valid.

      Attachments

        For Gerrit Dashboard: MB-49837
        # Subject Branch Project Status CR V

        Activity

          Build couchbase-server-7.1.0-2058 contains backup commit e29989e with commit message:
          MB-49837 Avoid false negative in object store resume validation

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-2058 contains backup commit e29989e with commit message: MB-49837 Avoid false negative in object store resume validation

          No issues observed in regression post this change

          arunkumar Arunkumar Senthilnathan added a comment - No issues observed in regression post this change

          People

            james.lee James Lee
            james.lee James Lee
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty