Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-5025

flush should return an error until such a time as it works

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.7.2, 1.8.0, 2.0-developer-preview-3, 2.0-developer-preview-4
    • Fix Version/s: 1.8.1
    • Component/s: couchbase-bucket
    • Security Level: Public

      Description

      Until such a time as flush works, it should return an error. Optionally, flush should be enabled through cbflushctl in order to support testing with small datasets.

      See also:
      MB-4717 and MB-4601

      # Subject Project Status CR V
      For Gerrit Dashboard: &For+MB-5025=message:MB-5025

        Activity

        Hide
        ingenthr Matt Ingenthron added a comment -

        Assigning to Frank for triage.

        Show
        ingenthr Matt Ingenthron added a comment - Assigning to Frank for triage.
        Hide
        steve Steve Yen added a comment -

        assigning to Dipti for a faster decision on this

        Show
        steve Steve Yen added a comment - assigning to Dipti for a faster decision on this
        Hide
        ingenthr Matt Ingenthron added a comment -

        decision is to disable flush_all for 1.8.1 and provide a method for enabling it

        Show
        ingenthr Matt Ingenthron added a comment - decision is to disable flush_all for 1.8.1 and provide a method for enabling it
        Hide
        junyi Junyi Xie (Inactive) added a comment -

        Fix submitted to Gerrit at link:

        http://review.couchbase.org/#change,15002

        under code review.

        Show
        junyi Junyi Xie (Inactive) added a comment - Fix submitted to Gerrit at link: http://review.couchbase.org/#change,15002 under code review.
        Hide
        steve Steve Yen added a comment -

        moxi needs a test against this, as I'm not sure moxi expects an error from flush_all.

        Show
        steve Steve Yen added a comment - moxi needs a test against this, as I'm not sure moxi expects an error from flush_all.
        Hide
        junyi Junyi Xie (Inactive) added a comment -

        Hi Steve,
        We have already merged the change set. Can you please elaborate how to test moxi against this change set?

        Thanks,

        Junyi

        Show
        junyi Junyi Xie (Inactive) added a comment - Hi Steve, We have already merged the change set. Can you please elaborate how to test moxi against this change set? Thanks, Junyi
        Show
        junyi Junyi Xie (Inactive) added a comment - http://review.couchbase.org/#change,15002
        Hide
        junyi Junyi Xie (Inactive) added a comment -

        Hi Dipti,

        To enable flushall, you can add this in your the engine parameter file

        "flushall_enabled=true"

        To turn it off, you just need to remove this line. The default is off.

        Thanks.

        Junyi

        Show
        junyi Junyi Xie (Inactive) added a comment - Hi Dipti, To enable flushall, you can add this in your the engine parameter file "flushall_enabled=true" To turn it off, you just need to remove this line. The default is off. Thanks. Junyi
        Hide
        sharon Sharon Barr (Inactive) added a comment -

        We need to document that we need to enable it on each node separately .
        Engine parameters are not a "cluster" parameters.

        Show
        sharon Sharon Barr (Inactive) added a comment - We need to document that we need to enable it on each node separately . Engine parameters are not a "cluster" parameters.
        Hide
        thuan Thuan Nguyen added a comment -

        Integrated in github-ep-engine-2-0 #262 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/262/)
        MB-5025 disable flushall by default (Revision d9d123f4a54def7cf2cbaed6e0189d9b846002da)

        Result = SUCCESS
        Junyi Xie :
        Files :

        • ep_engine.cc
        • ep_testsuite.cc
        • docs/engine-params.org
        • ep_engine.h
        • Makefile.am
        • configuration.json
        Show
        thuan Thuan Nguyen added a comment - Integrated in github-ep-engine-2-0 #262 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/262/ ) MB-5025 disable flushall by default (Revision d9d123f4a54def7cf2cbaed6e0189d9b846002da) Result = SUCCESS Junyi Xie : Files : ep_engine.cc ep_testsuite.cc docs/engine-params.org ep_engine.h Makefile.am configuration.json
        Hide
        perry Perry Krug added a comment -

        Has this not yet been merged into a build? I am unable to toggle the flush_all command with build 789:

        [root@localhost ~]# /opt/couchbase/bin/cbflushctl localhost:11210 set flushall_enabled true
        setting flush param: flushall_enabled true
        Traceback (most recent call last):
        File "/opt/couchbase/lib/python/cbflushctl", line 87, in ?
        c.execute()
        File "/opt/couchbase/lib/python/clitool.py", line 43, in execute
        f[0](mc, *args[2:], **opts._dict_)
        File "/opt/couchbase/lib/python/cbflushctl", line 42, in set_param
        mc.set_flush_param(key, val)
        File "/opt/couchbase/lib/python/mc_bin_client.py", line 214, in set_flush_param
        return self._doCmd(memcacheConstants.CMD_SET_FLUSH_PARAM, key, val)
        File "/opt/couchbase/lib/python/mc_bin_client.py", line 104, in _doCmd
        return self._handleSingleResponse(opaque)
        File "/opt/couchbase/lib/python/mc_bin_client.py", line 97, in _handleSingleResponse
        cmd, opaque, cas, keylen, extralen, data = self._handleKeyedResponse(myopaque)
        File "/opt/couchbase/lib/python/mc_bin_client.py", line 93, in _handleKeyedResponse
        raise MemcachedError(errcode, rv)
        mc_bin_client.MemcachedError: Memcached error #1: Unknown config param
        [root@localhost ~]#

        Show
        perry Perry Krug added a comment - Has this not yet been merged into a build? I am unable to toggle the flush_all command with build 789: [root@localhost ~] # /opt/couchbase/bin/cbflushctl localhost:11210 set flushall_enabled true setting flush param: flushall_enabled true Traceback (most recent call last): File "/opt/couchbase/lib/python/cbflushctl", line 87, in ? c.execute() File "/opt/couchbase/lib/python/clitool.py", line 43, in execute f [0] (mc, *args [2:] , **opts._ dict _) File "/opt/couchbase/lib/python/cbflushctl", line 42, in set_param mc.set_flush_param(key, val) File "/opt/couchbase/lib/python/mc_bin_client.py", line 214, in set_flush_param return self._doCmd(memcacheConstants.CMD_SET_FLUSH_PARAM, key, val) File "/opt/couchbase/lib/python/mc_bin_client.py", line 104, in _doCmd return self._handleSingleResponse(opaque) File "/opt/couchbase/lib/python/mc_bin_client.py", line 97, in _handleSingleResponse cmd, opaque, cas, keylen, extralen, data = self._handleKeyedResponse(myopaque) File "/opt/couchbase/lib/python/mc_bin_client.py", line 93, in _handleKeyedResponse raise MemcachedError(errcode, rv) mc_bin_client.MemcachedError: Memcached error #1: Unknown config param [root@localhost ~] #
        Hide
        junyi Junyi Xie (Inactive) added a comment -

        Hi Dipiti,

        The fix has been merged to 1.8.1 as CBD-152.

        http://review.couchbase.org/#change,16283

        Let me close this bug if it is ok with you.

        Thanks

        Junyi

        Show
        junyi Junyi Xie (Inactive) added a comment - Hi Dipiti, The fix has been merged to 1.8.1 as CBD-152. http://review.couchbase.org/#change,16283 Let me close this bug if it is ok with you. Thanks Junyi
        Show
        junyi Junyi Xie (Inactive) added a comment - http://review.couchbase.org/#change,16283

          People

          • Assignee:
            junyi Junyi Xie (Inactive)
            Reporter:
            ingenthr Matt Ingenthron
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes