Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-50269

[CLI] 'no_ssl_verify' variable is incorrectly passed to functions that take 'verify' argument

    XMLWordPrintable

Details

    • Bug
    • Resolution: Not a Bug
    • Major
    • 7.1.0
    • 7.1.0
    • tools
    • None
    • Untriaged
    • 1
    • Unknown

    Description

      What is the issue?
      Right now the 'opts.no_ssl_verify' variable that is determined by the supplied '--no-ssl-verify' flag (and defaults to 'True'), is incorrectly supplied to a number of functions that take the 'verify' argument.

      The issue is that the meaning of the 'opts.no_ssl_verify' variable is that verification is not supposed to happen if it's value is True, however, in a number of function calls it is supplied for the 'verify' function argument as it is, meaning that the value of 'verify' is set to the opposite of the intended boolean value:

      verify = opts.no_ssl_verify
      

      What is the fix?
      Change all incorrect assignments to

      verify = not opts.no_ssl_verify
      

      Attachments

        For Gerrit Dashboard: MB-50269
        # Subject Branch Project Status CR V

        Activity

          People

            maks.januska Maksimiljans Januska
            maks.januska Maksimiljans Januska
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty