Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-5050

autofailover should not auto failover anybody when rebalance is marked as in-progress. Or at least be more careful there

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.0
    • Fix Version/s: 1.8.1
    • Component/s: ns_server
    • Security Level: Public

      Description

      In one of customers:

      • rebalance was running
      • node orchestrating rebalance failed
      • node orchestrating rebalance was automatically failed over by new master
      • node orchestrating rebalance re-joined (still thinking it was rebalancing see MB-5049)
      • we had config conflict and bad things as a result

      Looks like during rebalance we should just disable autofailover because during rebalance humans can take care of correct actions

      # Subject Project Status CR V
      For Gerrit Dashboard: &For+MB-5050=message:MB-5050

        Activity

        Hide
        dipti Dipti Borkar added a comment -

        Looks like this is a major code change, we should move to 1.8.2

        Show
        dipti Dipti Borkar added a comment - Looks like this is a major code change, we should move to 1.8.2
        Hide
        alkondratenko Aleksey Kondratenko (Inactive) added a comment -

        hm. It's not that major. And I've just uploaded fix into gerrit. http://review.couchbase.org/14789

        Show
        alkondratenko Aleksey Kondratenko (Inactive) added a comment - hm. It's not that major. And I've just uploaded fix into gerrit. http://review.couchbase.org/14789
        Hide
        Aliaksey Artamonau Aliaksey Artamonau added a comment -

        Fix merged.

        Show
        Aliaksey Artamonau Aliaksey Artamonau added a comment - Fix merged.
        Hide
        thuan Thuan Nguyen added a comment -

        Integrated in github-ns-server-2-0 #333 (See http://qa.hq.northscale.net/job/github-ns-server-2-0/333/)
        disallow automatic failover during rebalance.MB-5050 (Revision e7db1454427a6e9cfe0bb2730ba27f025c1fafab)

        Result = SUCCESS
        Aliaksey Artamonau :
        Files :

        • src/auto_failover_logic.erl
        • src/auto_failover.erl
        Show
        thuan Thuan Nguyen added a comment - Integrated in github-ns-server-2-0 #333 (See http://qa.hq.northscale.net/job/github-ns-server-2-0/333/ ) disallow automatic failover during rebalance. MB-5050 (Revision e7db1454427a6e9cfe0bb2730ba27f025c1fafab) Result = SUCCESS Aliaksey Artamonau : Files : src/auto_failover_logic.erl src/auto_failover.erl

          People

          • Assignee:
            alkondratenko Aleksey Kondratenko (Inactive)
            Reporter:
            alkondratenko Aleksey Kondratenko (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes