Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-51475

[CBM] Incremental range logic incorrect, range data from latest backup is always used

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 7.1.0
    • 7.1.0
    • tools
    • Untriaged
    • 1
    • Yes
    • Tools 2022-March

    Description

      What's the issue?
      'cbbackpumgr' will only ever resume from the latest backup, if that fails we'll always full backup.

      The issue is cause by an incorrect assignment:

      Broken

      prevBucket, ok := prevBackup.buckets[curBucket.name]
      

      Fixed

      prevBucket, ok = prevBackup.buckets[curBucket.name]
      

      This means we're never iterating backwards, we're only ever testing against the first backup.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Build couchbase-server-7.1.0-2499 contains backup commit d89480d with commit message:
          MB-51475 Correctly use previous backups in range calculations

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-2499 contains backup commit d89480d with commit message: MB-51475 Correctly use previous backups in range calculations

          Build couchbase-server-7.2.0-1018 contains backup commit d89480d with commit message:
          MB-51475 Correctly use previous backups in range calculations

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.2.0-1018 contains backup commit d89480d with commit message: MB-51475 Correctly use previous backups in range calculations

          Confirmed CBBM will now resume from non-latest backups and not perform a full backup. Closing.

          joe.mitchelljones Joe Mitchell Jones added a comment - Confirmed CBBM will now resume from non-latest backups and not perform a full backup. Closing.

          People

            joe.mitchelljones Joe Mitchell Jones
            james.lee James Lee
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty