Details
-
Task
-
Resolution: Unresolved
-
Major
-
None
-
Morpheus
-
None
-
1
Description
Clang-tidy-9 doesn't handle NOLINT declaratives correctly within macros, and will still fail a check, for instance:
#define BASE_MONOTONIC(NAME, TYPE, POLICY, LABELER, VARNAME) \
|
/* NOLINTNEXTLINE(modernize-avoid-c-arrays) */ \
|
constexpr static const char VARNAME##Label[] = #VARNAME; \
|
NAME<TYPE, POLICY, VARNAME##Label, LABELER> VARNAME
|
This is fixed form LLVM 11 and onwards, once we upgrade to LLVM 14 in CBD-4671 we will need to remove any code comments referencing this MB.