Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-51895

[Tooling] Clang-tidy-9 doesn't handle NOLINT correctly in Macros

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Major
    • None
    • Morpheus
    • couchbase-bucket
    • None
    • 1

    Description

      Clang-tidy-9 doesn't handle NOLINT declaratives correctly within macros, and will still fail a check, for instance:

      #define BASE_MONOTONIC(NAME, TYPE, POLICY, LABELER, VARNAME) \
          /* NOLINTNEXTLINE(modernize-avoid-c-arrays) */           \
          constexpr static const char VARNAME##Label[] = #VARNAME; \
          NAME<TYPE, POLICY, VARNAME##Label, LABELER> VARNAME
      

      This is fixed form LLVM 11 and onwards, once we upgrade to LLVM 14 in CBD-4671 we will need to remove any code comments referencing this MB.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            owend Daniel Owen
            richard.demellow Richard deMellow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty