Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-5203

collect_info should include "diag" information

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.0
    • Fix Version/s: 2.0-beta
    • Component/s: tools
    • Security Level: Public
    • Labels:

      Description

      To prevent having to ask the customer for two different sets of output, can we please include the information contained within http://<host>:8091/diag in the collect_info output? I don't think we "need" to just call that URL, but that might be easiest (though very inefficient since we're already calling browse_logs). It's just the top part of the 'diag' that's necessary

      # Subject Project Status CR V
      For Gerrit Dashboard: &For+MB-5203=message:MB-5203

        Activity

        Hide
        thuan Thuan Nguyen added a comment -

        Integrated in github-ns-server-2-0 #344 (See http://qa.hq.northscale.net/job/github-ns-server-2-0/344/)
        allow /diag without logs (for MB-5203) (Revision bfa74c9beea17a612703850f7ca3e3751487748c)

        Result = SUCCESS
        Aliaksey Kandratsenka :
        Files :

        • src/diag_handler.erl
        Show
        thuan Thuan Nguyen added a comment - Integrated in github-ns-server-2-0 #344 (See http://qa.hq.northscale.net/job/github-ns-server-2-0/344/ ) allow /diag without logs (for MB-5203 ) (Revision bfa74c9beea17a612703850f7ca3e3751487748c) Result = SUCCESS Aliaksey Kandratsenka : Files : src/diag_handler.erl
        Hide
        dipti Dipti Borkar added a comment -

        Steve, I think you have had a chance to investigate the work that's needed here. Can you please post comments to this bug?

        Show
        dipti Dipti Borkar added a comment - Steve, I think you have had a chance to investigate the work that's needed here. Can you please post comments to this bug?
        Hide
        steve Steve Yen added a comment -

        Current cmd-line is...

        cbcollect_info output.zip

        Proposed cmd-line...

        cbcollect_info [--user Administrator] [--password password] output.zip

        If the user & password is provided, then do the optional HTTP $host:8091/diag request, probably with HTTP basic auth.

        Might be able to use curl.

        Show
        steve Steve Yen added a comment - Current cmd-line is... cbcollect_info output.zip Proposed cmd-line... cbcollect_info [--user Administrator] [--password password] output.zip If the user & password is provided, then do the optional HTTP $host:8091/diag request, probably with HTTP basic auth. Might be able to use curl.
        Hide
        perry Perry Krug added a comment -

        Is that really necessary? Surely we can get the same information out of erlang without requiring the username/pass? It will just add to the complexity of support having to explain how to use this tool to the user...and all of the ones that currently use it a) will have to change and b) might forget to and defeat the purpose altogether.

        I'm going to have to push back on requiring the username/pass since we currently get all that we need without it.

        Show
        perry Perry Krug added a comment - Is that really necessary? Surely we can get the same information out of erlang without requiring the username/pass? It will just add to the complexity of support having to explain how to use this tool to the user...and all of the ones that currently use it a) will have to change and b) might forget to and defeat the purpose altogether. I'm going to have to push back on requiring the username/pass since we currently get all that we need without it.
        Hide
        bcui Bin Cui (Inactive) added a comment -

        Perry's concerns are legit. We won't change the current arguments for cbcollect_info. And we will add the missing upper part to collect_info result.

        Show
        bcui Bin Cui (Inactive) added a comment - Perry's concerns are legit. We won't change the current arguments for cbcollect_info. And we will add the missing upper part to collect_info result.
        Hide
        thuan Thuan Nguyen added a comment -

        Integrated in github-ns-server-2-0 #349 (See http://qa.hq.northscale.net/job/github-ns-server-2-0/349/)
        mb-5203 add manifest to collect_info (Revision a6689681145c038f878c6fd26d565e50aac858ce)

        Result = SUCCESS

        Show
        thuan Thuan Nguyen added a comment - Integrated in github-ns-server-2-0 #349 (See http://qa.hq.northscale.net/job/github-ns-server-2-0/349/ ) mb-5203 add manifest to collect_info (Revision a6689681145c038f878c6fd26d565e50aac858ce) Result = SUCCESS
        Show
        steve Steve Yen added a comment - http://review.couchbase.org/#change,15763
        Hide
        steve Steve Yen added a comment -

        Bin did this is a way where optional user/pswd aren't needed.

        Bin just looked at what /diag was providing above and beyond cbcollect_info and added what he could to cbcollect_info in a way such that he didn't need to query a running ns_server process.

        Show
        steve Steve Yen added a comment - Bin did this is a way where optional user/pswd aren't needed. Bin just looked at what /diag was providing above and beyond cbcollect_info and added what he could to cbcollect_info in a way such that he didn't need to query a running ns_server process.
        Hide
        steve Steve Yen added a comment -

        reopening to remind farshid about the 1.8.1 manifest update that's needed if this can still make 1.8.1

        Show
        steve Steve Yen added a comment - reopening to remind farshid about the 1.8.1 manifest update that's needed if this can still make 1.8.1
        Hide
        steve Steve Yen added a comment -

        The last comment was wrong - meant for a different bug.

        Show
        steve Steve Yen added a comment - The last comment was wrong - meant for a different bug.
        Hide
        steve Steve Yen added a comment -

        looks like collecting /diag is important...

        reopening this bug to get these additional steps...

        1) get the REST user/pswd out of the cbdumpconfig.escript (rest_creds).
        2) using the REST user/pswd to grab a CURL /diag output into the cbcollect_info zip file.

        Show
        steve Steve Yen added a comment - looks like collecting /diag is important... reopening this bug to get these additional steps... 1) get the REST user/pswd out of the cbdumpconfig.escript (rest_creds). 2) using the REST user/pswd to grab a CURL /diag output into the cbcollect_info zip file.
        Hide
        thuan Thuan Nguyen added a comment -

        Integrated in github-ns-server-2-0 #364 (See http://qa.hq.northscale.net/job/github-ns-server-2-0/364/)
        MB-5203 Include diag in collect_info (Revision 10f86975df888e2860dc7007e110dc988e5103bc)

        Result = SUCCESS
        Aliaksey Kandratsenka :
        Files :

        • cbcollect_info
        Show
        thuan Thuan Nguyen added a comment - Integrated in github-ns-server-2-0 #364 (See http://qa.hq.northscale.net/job/github-ns-server-2-0/364/ ) MB-5203 Include diag in collect_info (Revision 10f86975df888e2860dc7007e110dc988e5103bc) Result = SUCCESS Aliaksey Kandratsenka : Files : cbcollect_info

          People

          • Assignee:
            bcui Bin Cui (Inactive)
            Reporter:
            perry Perry Krug
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: