Add settings needed for file-based-rebalance in Indexer.

Hareen Kancharla

  4:42 PM

H’e’y Folks - I have a metakv question pertaining to indexer settings; specifically the “/indexing/settings/config” key. I was trying to add a new setting under this key for passing the “rebalance S3 Path” to indexer and somehow indexer at some point updated the “indexing/setting/config” key without the “rebalance S3 Path” setting (indexer.settings.rebalance.remote_path) which ended up crashing ns_server constantly. Why would indexer update this key?

127.0.0.1 - @index [27/Sep/2022:16:31:52 -0700] "GET /_metakv/indexing/settings/config HTTP/1.1" 200 1281 - "Go-http-client/1.1" 3

[ns_server:debug,2022-09-27T16:31:52.033-07:00,n_0@127.0.0.1:<0.4487.0>:menelaus_metakv:handle_normal_get:60]HKHK: Get key - <<"/indexing/settings/config">>, Value - <<"{\"indexer.settings.rebalance.redistribute_indexes\":false,\"indexer.settings.compaction.days_of_week\":\"Sunday,Monday,Tuesday,Wednesday,Thursday,Friday,Saturday\",\"indexer.settings.compaction.interval\":\"00:00,00:00\",\"indexer.settings.persisted_snapshot.interval\":5000,\"indexer.settings.log_level\":\"info\",\"indexer.settings.compaction.compaction_mode\":\"circular\",\"indexer.settings.compaction.min_frag\":30,\"indexer.settings.enable_page_bloom_filter\":false,\"indexer.settings.inmemory_snapshot.interval\":200,\"indexer.settings.thresholds.mem_high\":80,\"indexer.settings.max_cpu_percent\":0,\"indexer.settings.storage_mode\":\"plasma\",\"indexer.settings.recovery.max_rollbacks\":2,\"indexer.settings.memory_quota\":536870912,\"indexer.settings.num_replica\":1,\"indexer.settings.rebalance.remote_path\":\"\", -------------------------> HK: this key is not present in the PUT below.

\"indexer.settings.compaction.abort_exceed_interval\":false,\"indexer.settings.thresholds.mem_low\":60}">>

127.0.0.1 - @index [27/Sep/2022:16:31:52 -0700] "PUT /_metakv/indexing/settings/config HTTP/1.1" 200 0 - "Go-http-client/1.1" 2

[ns_server:debug,2022-09-27T16:31:52.035-07:00,n_0@127.0.0.1:<0.4487.0>:menelaus_metakv:handle_mutate:85]HKHK: Put key - <<"/indexing/settings/config">>, Value - <<"{\"indexer.plasma.backIndex.enablePageBloomFilter\":false,\"indexer.settings.compaction.abort_exceed_interval\":false,\"indexer.settings.compaction.compaction_mode\":\"circular\",\"indexer.settings.compaction.days_of_week\":\"Sunday,Monday,Tuesday,Wednesday,Thursday,Friday,Saturday\",\"indexer.settings.compaction.interval\":\"00:00,00:00\",\"indexer.settings.compaction.min_frag\":30,\"indexer.settings.enable_page_bloom_filter\":false,\"indexer.settings.inmemory_snapshot.interval\":200,\"indexer.settings.log_level\":\"info\",\"indexer.settings.max_cpu_percent\":0,\"indexer.settings.memory_quota\":536870912,\"indexer.settings.num_replica\":1,\"indexer.settings.persisted_snapshot.interval\":5000,\"indexer.settings.rebalance.redistribute_indexes\":false,\"indexer.settings.recovery.max_rollbacks\":2,\"indexer.settings.storage_mode\":\"plasma\",\"indexer.settings.thresholds.mem_high\":80,\"indexer.settings.thresholds.mem_low\":60}">>

4:43

^PS: I am not sure if this is correct channel - let me know if there is an another channel where this should get posted to. (edited) 

Deepkaran Salooja

  4:45 PM

@hareen.k

, yes indexer can write to the config key "/indexing/settings/config". This is required to support cases where indexer settings are changed via the indexer REST endpoint rather than ns-server’s REST endpoint.

4:46

In this case, I think we should add the new key to the indexer’s config as well. So it will not overwrite what ns-server is writing.

4:46

This is how it works for some of the other setting keys e.g. storage_mode

Hareen Kancharla

  4:46 PM

ah interesting! Makes sense. Thanks 

@Deepkaran

. Yup I think I can merge my change once the setting is added in Indexer too. (edited) 

Deepkaran Salooja

  4:47 PM

sure, please file an MB for indexing to add the key name to the config.

Hareen Kancharla

  4:47 PM

Sure. Thanks.