Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-53958

Pre-commit script in backup, cbbs and tools-common repositories exits quietly if git couchbase.tools.format.behaviour not set

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • master
    • master
    • tools
    • None
    • Untriaged
    • 1
    • Yes

    Description

      If the git parameter couchbase.tools.format.behaviour is not set, the pre-commit script in the backup, cbbs and tools-common repositories (https://github.com/couchbase/backup/blob/master/.githooks/pre-commit)
      will exit without an error message, and the commit won't take place.

      The readme states that no config value should be treated the same way as if the config value was "commit"

      Attachments

        For Gerrit Dashboard: MB-53958
        # Subject Branch Project Status CR V

        Activity

          Build couchbase-server-7.2.0-2214 contains backup commit 750f53f with commit message:
          MB-53958 Fix pre-commit script

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.2.0-2214 contains backup commit 750f53f with commit message: MB-53958 Fix pre-commit script

          Build couchbase-server-8.0.0-1130 contains backup commit 750f53f with commit message:
          MB-53958 Fix pre-commit script

          build-team Couchbase Build Team added a comment - Build couchbase-server-8.0.0-1130 contains backup commit 750f53f with commit message: MB-53958 Fix pre-commit script

          Build couchbase-server-7.5.0-3273 contains cbbs commit f2ed5eb with commit message:
          MB-53958 Fix pre-commit script

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.5.0-3273 contains cbbs commit f2ed5eb with commit message: MB-53958 Fix pre-commit script

          Build couchbase-server-8.0.0-1168 contains cbbs commit f2ed5eb with commit message:
          MB-53958 Fix pre-commit script

          build-team Couchbase Build Team added a comment - Build couchbase-server-8.0.0-1168 contains cbbs commit f2ed5eb with commit message: MB-53958 Fix pre-commit script

          People

            safian.ali Safian Ali
            safian.ali Safian Ali
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty