Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-55142

[TC] [Connstr] An omitted port should be -1 instead of 0

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • master
    • master
    • tools-common
    • None
    • Untriaged
    • 0
    • No

    Description

      What's the issue?
      The valid port range is 1-65535 (where 1-1023 are reserved), we currently use a zero value to indicate that the port hasn't been supplied by a user (in the connection string).

      While this doesn't haven't any immediate negative impact on connection string parsing/use, it is incorrect because zero use often used by OSs for special functionality (e.g. pick and unused port).

      What's the fix?
      We should use -1 instead of 0 for a port that wasn't provided by the user.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            james.lee James Lee
            james.lee James Lee
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty