Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-5613

add new binary protocol operation for Observe

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-beta
    • Component/s: couchbase-bucket
    • Security Level: Public
    • Labels:
      None

      Description

      To facilitate several use cases relating to applications wishing more information on durability and whether or not data will be considered in stale=false view requests, we should add an Observe command.

      The description of this command is covered here:
      http://www.couchbase.com/wiki/display/couchbase/Observe

      Note that previous attempts at using stats key did not work out because of the protocol required ASCII representation of results in stats key.

      # Subject Project Status CR V
      For Gerrit Dashboard: &For+MB-5613=message:MB-5613

        Activity

        Hide
        dipti Dipti Borkar added a comment -

        Chiyoung, please review the protocol defined by the SDK team located here: http://www.couchbase.com/wiki/display/couchbase/Observe and assign to the right person within the couchbase bucket team.

        Show
        dipti Dipti Borkar added a comment - Chiyoung, please review the protocol defined by the SDK team located here: http://www.couchbase.com/wiki/display/couchbase/Observe and assign to the right person within the couchbase bucket team.
        Hide
        avsej Sergey Avseyev added a comment -

        Related patch on gerrit: http://review.couchbase.org/17583

        Show
        avsej Sergey Avseyev added a comment - Related patch on gerrit: http://review.couchbase.org/17583
        Hide
        thuan Thuan Nguyen added a comment -

        Integrated in github-ep-engine-2-0 #324 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/324/)
        MB-5613: Refactor getKeyStats() function (Revision efab5e2d4870765d2d130c43f3d56406b999924a)
        MB-5613: Add observe command (Revision 3be4a02ad191dbcd97430257ffb7a0213baaaee8)

        Result = SUCCESS
        Mike Wiederhold :
        Files :

        • ep.hh
        • ep.cc
        • ep_engine.cc

        Mike Wiederhold :
        Files :

        • ep_testsuite.cc
        • command_ids.h
        • ep_engine.h
        • ep_engine.cc
        Show
        thuan Thuan Nguyen added a comment - Integrated in github-ep-engine-2-0 #324 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/324/ ) MB-5613 : Refactor getKeyStats() function (Revision efab5e2d4870765d2d130c43f3d56406b999924a) MB-5613 : Add observe command (Revision 3be4a02ad191dbcd97430257ffb7a0213baaaee8) Result = SUCCESS Mike Wiederhold : Files : ep.hh ep.cc ep_engine.cc Mike Wiederhold : Files : ep_testsuite.cc command_ids.h ep_engine.h ep_engine.cc
        Hide
        avsej Sergey Avseyev added a comment -

        I might be wrong, but it seems like the related patch doesn't send aggregated response in reply to multi-key observe. It behaves like stats, where the client is receiving multiple responses per each key.

        We described response in a bit different way here http://www.couchbase.com/wiki/display/couchbase/Observe#Observe-Response

        Correct me if I'm wrong

        Show
        avsej Sergey Avseyev added a comment - I might be wrong, but it seems like the related patch doesn't send aggregated response in reply to multi-key observe. It behaves like stats, where the client is receiving multiple responses per each key. We described response in a bit different way here http://www.couchbase.com/wiki/display/couchbase/Observe#Observe-Response Correct me if I'm wrong
        Hide
        avsej Sergey Avseyev added a comment -

        Sorry. I see it now

        Show
        avsej Sergey Avseyev added a comment - Sorry. I see it now
        Hide
        thuan Thuan Nguyen added a comment -

        Integrated in github-ep-engine-2-0 #325 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/325/)
        MB-5613: Fix array sizing error in observe test cases (Revision 4d642e15222ad4a2db08070324d1c6dae0d353cf)

        Result = SUCCESS
        Mike Wiederhold :
        Files :

        • ep_testsuite.cc
        Show
        thuan Thuan Nguyen added a comment - Integrated in github-ep-engine-2-0 #325 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/325/ ) MB-5613 : Fix array sizing error in observe test cases (Revision 4d642e15222ad4a2db08070324d1c6dae0d353cf) Result = SUCCESS Mike Wiederhold : Files : ep_testsuite.cc

          People

          • Assignee:
            mikew Mike Wiederhold
            Reporter:
            ingenthr Matt Ingenthron
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes