Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-6237

membase-cli, ep-engine & bucket-engine need agree on who installs mc_bin_client.py into $PREFIX/lib/python otherwise parallel build is subtly broken

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta
    • Fix Version/s: bug-backlog
    • Component/s: tools
    • Security Level: Public
    • Labels:
      None
    • Triage:
      Untriaged

      Description

      SUBJ. See below what this is causing:

      I've just found that ep-engine and membase-cli and bucket-engine all of them install it into $PREFIX/lib/python. And while there's dependency in bucket-engine on ep-engine, there's no dependency at all between those two and membase-cli. That's causing completely random final version of mc_client_binary.py

      NOTE: membase-cli and ep-engine seemingly install sample (according to md5sum) version of file. But bucket-engine's version differs.

      ------------------------------------------------------------

      1. ../../install/bin/cbepctl lh:12000 stop
        Traceback (most recent call last):
        File "/root/src/altoros/moxi/repo20-64/install/lib/python/cbepctl", line 169, in <module>
        c.execute()
        File "/root/src/altoros/moxi/repo20-64/install/lib/python/clitool.py", line 58, in execute
        f[0](mc, *args[2:], **opts._dict_)
        File "/root/src/altoros/moxi/repo20-64/install/lib/python/cbepctl", line 35, in g
        f(*args[:n])
        File "/root/src/altoros/moxi/repo20-64/install/lib/python/cbepctl", line 63, in stop
        mc.stop_persistence()
        AttributeError: 'MemcachedClient' object has no attribute 'stop_persistence'
      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        trond Trond Norbye added a comment -

        Peter: no, we should only have one copy of our code. Multiple copies will ALWAYS lead multiple versions of something that's intended to be the same... Out of the two remaining copies I think we should remove the copy in ep-engine, or move it into a separate repository where ep-engine and membase-cli may grab their copy from.

        Show
        trond Trond Norbye added a comment - Peter: no, we should only have one copy of our code. Multiple copies will ALWAYS lead multiple versions of something that's intended to be the same... Out of the two remaining copies I think we should remove the copy in ep-engine, or move it into a separate repository where ep-engine and membase-cli may grab their copy from.
        Hide
        steve Steve Yen added a comment -

        more sensible assignment than peter

        Show
        steve Steve Yen added a comment - more sensible assignment than peter
        Hide
        steve Steve Yen added a comment -

        Bin, I think you did something recently to address this?

        Show
        steve Steve Yen added a comment - Bin, I think you did something recently to address this?
        Hide
        bcui Bin Cui added a comment -

        for membase-cli, we work around the problem instead of fixing it. we rename mc_bin_client.py to a different file name

        Show
        bcui Bin Cui added a comment - for membase-cli, we work around the problem instead of fixing it. we rename mc_bin_client.py to a different file name
        Hide
        steve Steve Yen added a comment -

        resolved based on bin's last comment

        Show
        steve Steve Yen added a comment - resolved based on bin's last comment

          People

          • Assignee:
            bcui Bin Cui
            Reporter:
            alkondratenko Aleksey Kondratenko (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes