Details
-
Improvement
-
Resolution: Fixed
-
Critical
-
2.0-beta-2
-
Security Level: Public
-
None
Description
In effort to fix MB-6619, we change the ensure_full_commit from actively polling ep_engine stats during checkpointing, to event notification manner that it only gets notified when the checkpoint id changes. Today mc_connection:do_notify_vbucket_update() push event to event manager whenever the vbstate changes, which covers much more than checkpoint ID change. To avoid overhead to parse a large amount of unwanted msg from event manager, ep_engine need to provides a boolean flag to indicate that in this event, the checkpoint ID changes or not. Then we can filter out all other events involving no checkpoint change.
This may involves a protocol change between ep_engine and ns_server, commits on both sides need to be merged at the same time.
Attachments
For Gerrit Dashboard: MB-6632 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
20810,3 | MB-6632 Extend couch_notification msg to notify checkpoint changes | master | ep-engine | Status: MERGED | +2 | +1 |
20868,4 | MB-6632 Create a new checkpoint even if the current one is empty | master | ep-engine | Status: MERGED | +2 | +1 |
20869,2 | MB-6632 Schedule vb state snapshot task for checkpoint changes | master | ep-engine | Status: MERGED | +2 | +1 |