Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-6876

couchbase 2.0 does not build with libconflate master branch

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.0.1, 2.1.0
    • Fix Version/s: 3.0
    • Component/s: build
    • Security Level: Public
    • Labels:
      None

      Description

      for now we forked off a branch-20

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        farshid Farshid Ghods (Inactive) added a comment -

        Ah, I think I see the problem. libcurl is installed in a "non-standard" path so we're not picking it up. Pandora did some auto-magic there which Alk also said was "wrong" so we're not doing that anymore.. I guess we need to add

        'LDFLAGS=-L/opt/couchbase/lib' 'CPPFLAGS=-I/opt/couchbase/include'

        for servers where we would like to use local versions instead of the system provided ones.. I can add that to the Toplevel Makefile if you like..

        Trond

        On 26. sep. 2012, at 11:49, Farshid Ghods <farshid@couchbase.com> wrote:

        i restarted the build after removing the dep-*.tar.gz file and seems like lib curl is being built but lib conflate still fails

        logs here :

        http://builds.hq.northscale.net:8010/builders/ubuntu-x64-20-builder/builds/744/steps/couchbase-server%20make%20enterprise%20/logs/stdio

        On Sep 26, 2012, at 11:28 AM, Trond Norbye wrote:

        The only thing I've changed for libconflate is that I've removed the macros used to check if the library is present or not. Previously we used the pandora macros for this (which Alk really dislikes, and there are other problems with them), and now I've made this into a smaller project that use our own check macros.

        I've not changed what voltron builds/doesn't builds..

        Cheers,

        Trond

        Show
        farshid Farshid Ghods (Inactive) added a comment - Ah, I think I see the problem. libcurl is installed in a "non-standard" path so we're not picking it up. Pandora did some auto-magic there which Alk also said was "wrong" so we're not doing that anymore.. I guess we need to add 'LDFLAGS=-L/opt/couchbase/lib' 'CPPFLAGS=-I/opt/couchbase/include' for servers where we would like to use local versions instead of the system provided ones.. I can add that to the Toplevel Makefile if you like.. Trond On 26. sep. 2012, at 11:49, Farshid Ghods <farshid@couchbase.com> wrote: i restarted the build after removing the dep-*.tar.gz file and seems like lib curl is being built but lib conflate still fails logs here : http://builds.hq.northscale.net:8010/builders/ubuntu-x64-20-builder/builds/744/steps/couchbase-server%20make%20enterprise%20/logs/stdio On Sep 26, 2012, at 11:28 AM, Trond Norbye wrote: The only thing I've changed for libconflate is that I've removed the macros used to check if the library is present or not. Previously we used the pandora macros for this (which Alk really dislikes, and there are other problems with them), and now I've made this into a smaller project that use our own check macros. I've not changed what voltron builds/doesn't builds.. Cheers, Trond
        Hide
        dipti Dipti Borkar added a comment -

        Any reason we need this in the near future?

        Show
        dipti Dipti Borkar added a comment - Any reason we need this in the near future?
        Hide
        plabee Phil Labee (Inactive) added a comment -

        added default values:

        LDFLAGS=-L/opt/couchbase/lib
        CPPFLAGS=-I/opt/couchbase/include

        to Makefile.top

        Show
        plabee Phil Labee (Inactive) added a comment - added default values: LDFLAGS=-L/opt/couchbase/lib CPPFLAGS=-I/opt/couchbase/include to Makefile.top
        Hide
        plabee Phil Labee (Inactive) added a comment -

        My changes don't address the issue, which was poorly described.

        The libconflate code was broken just after the 2.0 branch. Because this will keep builds from completing, a workaround was implemented, which is to use the branch-20 version of libconflate. Fortunately there haven't been any bug fixes or feature added to either branch since.

        I recommend that we revert that changes that broke the build, then start using the master branch for 2.1 builds. If the need to make those changes continues, they can be done in a way that doesn't break.

        Show
        plabee Phil Labee (Inactive) added a comment - My changes don't address the issue, which was poorly described. The libconflate code was broken just after the 2.0 branch. Because this will keep builds from completing, a workaround was implemented, which is to use the branch-20 version of libconflate. Fortunately there haven't been any bug fixes or feature added to either branch since. I recommend that we revert that changes that broke the build, then start using the master branch for 2.1 builds. If the need to make those changes continues, they can be done in a way that doesn't break.
        Hide
        plabee Phil Labee (Inactive) added a comment -

        Please examine your changes since
        3cf7107eaa5b52b34cc9f887cf0e2edb3465988e

        Show
        plabee Phil Labee (Inactive) added a comment - Please examine your changes since 3cf7107eaa5b52b34cc9f887cf0e2edb3465988e
        Hide
        maria Maria McDuff (Inactive) added a comment -

        not part of 2.0.2 release. assigning to wayne for investigation.

        Show
        maria Maria McDuff (Inactive) added a comment - not part of 2.0.2 release. assigning to wayne for investigation.
        Hide
        wayne Wayne Siu added a comment -

        Trond, is this something that you could help to look at? Thanks.

        Show
        wayne Wayne Siu added a comment - Trond, is this something that you could help to look at? Thanks.
        Hide
        trond Trond Norbye added a comment -

        Yes. can we please start building the 2.1-unstable branch as part of buildbot and not the 2.1-stable.xml thing (which is using pinned versions and hence not that interesting )

        Show
        trond Trond Norbye added a comment - Yes. can we please start building the 2.1-unstable branch as part of buildbot and not the 2.1-stable.xml thing (which is using pinned versions and hence not that interesting )
        Hide
        plabee Phil Labee (Inactive) added a comment -

        That's a good idea.

        I've changed the 2.1 buildbot builds to use 2.1-unstable.xml

        Show
        plabee Phil Labee (Inactive) added a comment - That's a good idea. I've changed the 2.1 buildbot builds to use 2.1-unstable.xml

          People

          • Assignee:
            trond Trond Norbye
            Reporter:
            farshid Farshid Ghods (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews