Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-7322

WINDOWS: bat files should be formatted with Windows compliant cariag

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta
    • Fix Version/s: bug-backlog
    • Component/s: installer
    • Security Level: Public
    • Labels:
    • Environment:
      Working with build 2.0.0 1956
    • Triage:
      Untriaged

      Description

      On Windows platform we have many BAT scripts that are stored in C:\Program Files\Couchbase\Server\bin\

      All the files are UNIX Formatted, this means that default Windows tools such as "Notepad" are not able to open the file properly.

      We need to be sure that Windows related files are properly formatted.

      These files are usually not used by the administrators but in some case it is necessary see http://www.couchbase.com/docs/couchbase-manual-2.0/couchbase-bestpractice-cloud-ip.html

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        farshid Farshid Ghods (Inactive) added a comment -

        deferring to 2.1 per bug scrub meeting ( Dipti & Farshid -December 7th )

        Show
        farshid Farshid Ghods (Inactive) added a comment - deferring to 2.1 per bug scrub meeting ( Dipti & Farshid -December 7th )
        Hide
        maria Maria McDuff (Inactive) added a comment -

        moving to .next. will revisit after 2.1. release.

        Show
        maria Maria McDuff (Inactive) added a comment - moving to .next. will revisit after 2.1. release.
        Hide
        siri Sriram Melkote added a comment -

        Ceej - you mentioned on http://review.couchbase.org/#/c/36783/ that there's a way to fix this using git settings on Windows builder.

        So assigning to you to do the needful.

        Let's fix this in 3.0 or merge http://review.couchbase.org/#/c/36783/ as it's been open for too long.

        Show
        siri Sriram Melkote added a comment - Ceej - you mentioned on http://review.couchbase.org/#/c/36783/ that there's a way to fix this using git settings on Windows builder. So assigning to you to do the needful. Let's fix this in 3.0 or merge http://review.couchbase.org/#/c/36783/ as it's been open for too long.
        Hide
        ceej Chris Hillery added a comment -

        I've configured the Windows build server accordingly (git config --global core.autocrlf true). Let me know if future installers include files that do not have appropriate line endings.

        Show
        ceej Chris Hillery added a comment - I've configured the Windows build server accordingly (git config --global core.autocrlf true). Let me know if future installers include files that do not have appropriate line endings.

          People

          • Assignee:
            thuan Thuan Nguyen
            Reporter:
            tgrall Tug Grall (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes