Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-7347

couchstore python exposure of header_position off_t is 64-bits

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 3.0
    • Component/s: storage-engine
    • Security Level: Public
    • Labels:
      None

      Description

      For the ctypes-exposed dbdocinfo structure, the header_position field of type off_t was incorrectly (by me) exposed as a size_t.

      From alk...

      As noted on gerrit's commit I believe at least on all supported OSes off_t is 64-bit wide.

      # Subject Project Status CR V
      For Gerrit Dashboard: &For+MB-7347=message:MB-7347

        Activity

        Hide
        farshid Farshid Ghods (Inactive) added a comment -

        per bug scrub , moving to 2.1

        Show
        farshid Farshid Ghods (Inactive) added a comment - per bug scrub , moving to 2.1
        Hide
        maria Maria McDuff (Inactive) added a comment -

        Alk, is this a must-have for 3.0? pls update.

        Show
        maria Maria McDuff (Inactive) added a comment - Alk, is this a must-have for 3.0? pls update.
        Hide
        alkondratenko Aleksey Kondratenko (Inactive) added a comment -

        I believe it is good enough to be a blocker. I.e. for backup etc.

        But might be fixed already.

        Passing to tools folks and CC-ed Aaron.

        Show
        alkondratenko Aleksey Kondratenko (Inactive) added a comment - I believe it is good enough to be a blocker. I.e. for backup etc. But might be fixed already. Passing to tools folks and CC-ed Aaron.
        Hide
        aaron Aaron Miller (Inactive) added a comment -
        Show
        aaron Aaron Miller (Inactive) added a comment - Not fixed yet, just changing this to ulonglong; https://github.com/couchbase/couchstore/blob/master/python/couchstore.py#L106 I
        Show
        aaron Aaron Miller (Inactive) added a comment - http://review.couchbase.org/#/c/29590/

          People

          • Assignee:
            ketaki Ketaki Gangal
            Reporter:
            steve Steve Yen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes