Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-7435

ns_server needs better way to calculate TAP stats.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1.0
    • Component/s: couchbase-bucket
    • Security Level: Public
    • Labels:
      None

      Description

      In order to calculate TAP stats ns_server requests "tapagg _" stats from ep-engine and differentiates them to calculate rates. But the problem with this approach is that ep-engine aggregates stats only for the TAP streams that currently exist. Hence ns_server is not able to account for part of the information because it's completely lost whenever some TAP stream is killed. What's more, it prevented us from implementing more detailed rebalance progress because the estimated number of transferred items was significantly different from the actual one. So we'll probably need some way to keep aggregated stats in ep-engine while rebalance is in progress.

        Issue Links

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          deepkaran.salooja Deepkaran Salooja added a comment -

          Assigning this to Iryna as she is working on the rebalance progress testing.

          Iryna,

          Please take a note of the information in this bug and update it with your findings about the accuracy of the rebalance progress stats.

          Show
          deepkaran.salooja Deepkaran Salooja added a comment - Assigning this to Iryna as she is working on the rebalance progress testing. Iryna, Please take a note of the information in this bug and update it with your findings about the accuracy of the rebalance progress stats.
          Hide
          mikew Mike Wiederhold added a comment -

          Iryna,

          If you find any issues related to rebalance please file new issues and assign them to me.

          Show
          mikew Mike Wiederhold added a comment - Iryna, If you find any issues related to rebalance please file new issues and assign them to me.
          Hide
          maria Maria McDuff (Inactive) added a comment -

          iryna,

          you can go ahead and close this bug and file new ones for new issues.
          Thanks.

          Show
          maria Maria McDuff (Inactive) added a comment - iryna, you can go ahead and close this bug and file new ones for new issues. Thanks.
          Hide
          iryna iryna added a comment -

          build 2.0.2-786 verified

          Show
          iryna iryna added a comment - build 2.0.2-786 verified
          Hide
          thuan Thuan Nguyen added a comment -

          Integrated in github-ep-engine-2-0 #488 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/488/)
          MB-7435: Account for chk start in numOpenChkItems (Revision 7923844f13d89d01eefc1823254476df5092550d)
          MB-7435: Make sure chk_items always gets a value (Revision e94e5336f9107f1375504b205a114902b66af374)

          Result = SUCCESS
          Mike Wiederhold :
          Files :

          • tests/ep_testsuite.cc
          • src/checkpoint.cc

          Mike Wiederhold :
          Files :

          • src/ep_engine.cc
          Show
          thuan Thuan Nguyen added a comment - Integrated in github-ep-engine-2-0 #488 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/488/ ) MB-7435 : Account for chk start in numOpenChkItems (Revision 7923844f13d89d01eefc1823254476df5092550d) MB-7435 : Make sure chk_items always gets a value (Revision e94e5336f9107f1375504b205a114902b66af374) Result = SUCCESS Mike Wiederhold : Files : tests/ep_testsuite.cc src/checkpoint.cc Mike Wiederhold : Files : src/ep_engine.cc

            People

            • Assignee:
              iryna iryna
              Reporter:
              Aliaksey Artamonau Aliaksey Artamonau
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes