Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-7726

reAddNode endpoint doesn't validate otpNode (was: reAddNode returning HTTP 200 on garbled input)

    Details

    • Triage:
      Untriaged
    • Is this a Regression?:
      No

      Description

      -----------------------------------------------------------------------------

      mnunberg@csure:~/src/cbsdkd-stable$ curl -X POST -u Administrator:123456 http://10.6.2.78:8091/controller/reAddNode -d 'kjhkjlhkaskjlsjas' -vvv

      • About to connect() to 10.6.2.78 port 8091 (#0)
      • Trying 10.6.2.78...
      • connected
      • Connected to 10.6.2.78 (10.6.2.78) port 8091 (#0)
      • Server auth using Basic with user 'Administrator'
        > POST /controller/reAddNode HTTP/1.1
        > Authorization: Basic QWRtaW5pc3RyYXRvcjoxMjM0NTY=
        > User-Agent: curl/7.26.0
        > Host: 10.6.2.78:8091
        > Accept: /
        > Content-Length: 17
        > Content-Type: application/x-www-form-urlencoded
        >
      • upload completely sent off: 17 out of 17 bytes
      • additional stuff not fine transfer.c:1037: 0 0
      • HTTP 1.1 or later with persistent connection, pipelining supported
        < HTTP/1.1 200 OK
        < Server: MochiWeb/1.0 (Any of you quaids got a smint?)
        < Date: Tue, 12 Feb 2013 18:41:54 GMT
        < Content-Length: 0
        <
      • Connection #0 to host 10.6.2.78 left intact
      • Closing connection #0

      -----------------------------------------------------------------------------

      This might be a known issue, but I haven't seen this in a cursory search for 'reAddNode', so mentioning it here.

      I've not tried with every single type of input variation, but I came across this when trying to "re-add" nodes but they did not actually end up getting re-added..

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        alkondratenko Aleksey Kondratenko (Inactive) added a comment -

        Fixed by: http://review.couchbase.org/42210 (note, it incorrectly refers to MB-7226)

        Show
        alkondratenko Aleksey Kondratenko (Inactive) added a comment - Fixed by: http://review.couchbase.org/42210 (note, it incorrectly refers to MB-7226 )

          People

          • Assignee:
            alkondratenko Aleksey Kondratenko (Inactive)
            Reporter:
            mnunberg Mark Nunberg
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes