Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-7845

change ns_server,couchdb and other makefile to use PRODUCT_VERSION instead of git_describe if this env variable is defined

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.1.0
    • Fix Version/s: 3.0
    • Component/s: build
    • Security Level: Public
    • Labels:
      None
    • Sprint:
      Build Team May 13th Sprint, Jul 8th Sprint

      Issue Links

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        steve Steve Yen added a comment -

        from farshid – this would allow hot fixes without changing any of the paths.

        Instead of this...
        /opt/couchbase/nsxyz-1.8.1_gAAAAAA

        We'd get something better.

        Show
        steve Steve Yen added a comment - from farshid – this would allow hot fixes without changing any of the paths. Instead of this... /opt/couchbase/nsxyz-1.8.1_gAAAAAA We'd get something better.
        Hide
        steve Steve Yen added a comment -

        Related, there was another issue where RPM for 1.8.1 was different than DEB for 1.8.1, so this could be helpful to avoid doing that again.

        Show
        steve Steve Yen added a comment - Related, there was another issue where RPM for 1.8.1 was different than DEB for 1.8.1, so this could be helpful to avoid doing that again.
        Hide
        maria Maria McDuff (Inactive) added a comment -

        phil,

        any update on this?

        Show
        maria Maria McDuff (Inactive) added a comment - phil, any update on this?
        Hide
        plabee Phil Labee (Inactive) added a comment -

        => find . -type f | xargs grep 'git describe' 2>&1 | grep -v 'Binary file' | grep -v 'No such file'

        ./report.rb: PRODUCT_VERSION = `git describe --long --always`.chomp
        ./report.rb: g = `git describe --long --always`.chomp
        ./kick:x = `git describe` # Looks like "1.6.4r-17-g65d9478"
        ./manifest.rb: PRODUCT_VERSION = `git describe --long --always`.chomp
        ./Makefile:PRODUCT_VERSION := $(shell git describe)
        ./build/ns_server/deps/ale/Makefile:`([ -f VERSION ] && cat VERSION) || git describe --always`
        ./build/ns_server/Makefile: mkdir p tmp/ns_server`git describe`
        ./build/ns_server/Makefile: rm rf tmp/ns_server`git describe`/*
        ./build/ns_server/Makefile: cp configure tmp/ns_server-`git describe`/
        ./build/ns_server/Makefile: cp R LICENSE Makefile README* cluster* common* cb* couchbase* rebar* tmp/ns_server`git describe`/
        ./build/ns_server/Makefile: cp R deps doc etc include priv scripts src test tmp/ns_server`git describe`/
        ./build/ns_server/Makefile: find tmp/ns_server-`git describe` -name '*.beam' | xargs rm -f
        ./build/ns_server/Makefile: tar C tmp -czf ns_server`git describe`.tar.gz ns_server-`git describe`
        ./build/ns_server/Makefile: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/libconflate/Makefile.am: (cat Doxyfile ; echo "PROJECT_NUMBER=`git describe`") | doxygen -
        ./build/libconflate/Makefile: (cat Doxyfile ; echo "PROJECT_NUMBER=`git describe`") | doxygen -
        ./build/libconflate/config/version.pl:my $version = `git describe`;
        ./build/libconflate/Makefile.in: (cat Doxyfile ; echo "PROJECT_NUMBER=`git describe`") | doxygen -
        ./build/couchbase-examples/config/version.pl:my $version = `git describe`;
        ./build/healthchecker/Makefile.am: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/healthchecker/Makefile.mingw: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/healthchecker/Makefile: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/healthchecker/config/version.pl:my $version = `git describe`;
        ./build/healthchecker/Makefile.in: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/libvbucket/packaging/deb/package.mk:# $ git describe
        ./build/libvbucket/packaging/deb/package.mk:# $ git describe
        ./build/libvbucket/config/version.pl:my $version = `git describe`;
        ./build/testrunner/scripts/perf/parent:git describe --always --long
        ./build/testrunner/scripts/perf/client:git describe --always --long
        ./build/geocouch/Makefile:VERSION=$(shell git describe)
        ./build/memcached/win32/config.sh:MEMC_VERSION=`git describe | tr '-' '_'`;
        ./build/memcached/config/version.pl:my $version = `git describe`;
        ./build/couchstore/config/version.pl:my $version = `git describe`;
        ./build/moxi/Makefile.am: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/moxi/Makefile: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/moxi/config/version.pl:my $version = `git describe`;
        ./build/moxi/Makefile.in: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/bucket_engine/win32/config.sh:MEMC_VERSION=`git describe | tr '-' '_'`;
        ./build/bucket_engine/config/version.pl:my $version = `git describe`;
        ./build/Makefile:DIST_VERSION = `git describe`
        ./build/ep-engine/win32/config.sh:MEMC_VERSION=`git describe | tr '-' '_'`;
        ./build/ep-engine/config/version.pl:my $version = `git describe`;
        ./build/couchbase-cli/Makefile.am: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/couchbase-cli/Makefile: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/couchbase-cli/config/version.pl:my $version = `git describe`;
        ./build/couchbase-cli/Makefile.in: git describe | sed s/-/_/g > $(TMP_VER)
        ./build/couchdbx-app/Makefile:PRODUCT_VERSION := $(shell git describe)
        ./build/tlm/Makefile.top:DIST_VERSION = `git describe`
        ./build/couchbase-python-client/setup.py: p = subprocess.Popen('git describe', stdout=subprocess.PIPE, shell=True)
        ./build/couchbase-python-client/config/version.pl:my $version = `git describe`;

        Show
        plabee Phil Labee (Inactive) added a comment - => find . -type f | xargs grep 'git describe' 2>&1 | grep -v 'Binary file' | grep -v 'No such file' ./report.rb: PRODUCT_VERSION = `git describe --long --always`.chomp ./report.rb: g = `git describe --long --always`.chomp ./kick:x = `git describe` # Looks like "1.6.4r-17-g65d9478" ./manifest.rb: PRODUCT_VERSION = `git describe --long --always`.chomp ./Makefile:PRODUCT_VERSION := $(shell git describe) ./build/ns_server/deps/ale/Makefile:`([ -f VERSION ] && cat VERSION) || git describe --always` ./build/ns_server/Makefile: mkdir p tmp/ns_server `git describe` ./build/ns_server/Makefile: rm rf tmp/ns_server `git describe`/* ./build/ns_server/Makefile: cp configure tmp/ns_server-`git describe`/ ./build/ns_server/Makefile: cp R LICENSE Makefile README* cluster* common* cb* couchbase* rebar* tmp/ns_server `git describe`/ ./build/ns_server/Makefile: cp R deps doc etc include priv scripts src test tmp/ns_server `git describe`/ ./build/ns_server/Makefile: find tmp/ns_server-`git describe` -name '*.beam' | xargs rm -f ./build/ns_server/Makefile: tar C tmp -czf ns_server `git describe`.tar.gz ns_server-`git describe` ./build/ns_server/Makefile: git describe | sed s/-/_/g > $(TMP_VER) ./build/libconflate/Makefile.am: (cat Doxyfile ; echo "PROJECT_NUMBER=`git describe`") | doxygen - ./build/libconflate/Makefile: (cat Doxyfile ; echo "PROJECT_NUMBER=`git describe`") | doxygen - ./build/libconflate/config/version.pl:my $version = `git describe`; ./build/libconflate/Makefile.in: (cat Doxyfile ; echo "PROJECT_NUMBER=`git describe`") | doxygen - ./build/couchbase-examples/config/version.pl:my $version = `git describe`; ./build/healthchecker/Makefile.am: git describe | sed s/-/_/g > $(TMP_VER) ./build/healthchecker/Makefile.mingw: git describe | sed s/-/_/g > $(TMP_VER) ./build/healthchecker/Makefile: git describe | sed s/-/_/g > $(TMP_VER) ./build/healthchecker/config/version.pl:my $version = `git describe`; ./build/healthchecker/Makefile.in: git describe | sed s/-/_/g > $(TMP_VER) ./build/libvbucket/packaging/deb/package.mk:# $ git describe ./build/libvbucket/packaging/deb/package.mk:# $ git describe ./build/libvbucket/config/version.pl:my $version = `git describe`; ./build/testrunner/scripts/perf/parent:git describe --always --long ./build/testrunner/scripts/perf/client:git describe --always --long ./build/geocouch/Makefile:VERSION=$(shell git describe) ./build/memcached/win32/config.sh:MEMC_VERSION=`git describe | tr '-' '_'`; ./build/memcached/config/version.pl:my $version = `git describe`; ./build/couchstore/config/version.pl:my $version = `git describe`; ./build/moxi/Makefile.am: git describe | sed s/-/_/g > $(TMP_VER) ./build/moxi/Makefile: git describe | sed s/-/_/g > $(TMP_VER) ./build/moxi/config/version.pl:my $version = `git describe`; ./build/moxi/Makefile.in: git describe | sed s/-/_/g > $(TMP_VER) ./build/bucket_engine/win32/config.sh:MEMC_VERSION=`git describe | tr '-' '_'`; ./build/bucket_engine/config/version.pl:my $version = `git describe`; ./build/Makefile:DIST_VERSION = `git describe` ./build/ep-engine/win32/config.sh:MEMC_VERSION=`git describe | tr '-' '_'`; ./build/ep-engine/config/version.pl:my $version = `git describe`; ./build/couchbase-cli/Makefile.am: git describe | sed s/-/_/g > $(TMP_VER) ./build/couchbase-cli/Makefile: git describe | sed s/-/_/g > $(TMP_VER) ./build/couchbase-cli/config/version.pl:my $version = `git describe`; ./build/couchbase-cli/Makefile.in: git describe | sed s/-/_/g > $(TMP_VER) ./build/couchdbx-app/Makefile:PRODUCT_VERSION := $(shell git describe) ./build/tlm/Makefile.top:DIST_VERSION = `git describe` ./build/couchbase-python-client/setup.py: p = subprocess.Popen('git describe', stdout=subprocess.PIPE, shell=True) ./build/couchbase-python-client/config/version.pl:my $version = `git describe`;
        Hide
        maria Maria McDuff (Inactive) added a comment -

        Phil, is this fixed?

        Show
        maria Maria McDuff (Inactive) added a comment - Phil, is this fixed?
        Hide
        plabee Phil Labee (Inactive) added a comment -

        no

        Show
        plabee Phil Labee (Inactive) added a comment - no
        Hide
        plabee Phil Labee (Inactive) added a comment -

        This issue has come back again, and now goes beyond Makefiles. Current buildbot calls:

        PRODUCT_VERSION=0.0.0-174-rel ... make foo

        for linux and macosx builds.

        Show
        plabee Phil Labee (Inactive) added a comment - This issue has come back again, and now goes beyond Makefiles. Current buildbot calls: PRODUCT_VERSION=0.0.0-174-rel ... make foo for linux and macosx builds.

          People

          • Assignee:
            ceej Chris Hillery
            Reporter:
            farshid Farshid Ghods (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile

                Gerrit Reviews

                There are no open Gerrit changes