Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.0.1, 2.1.0
    • Fix Version/s: 2.2.0
    • Component/s: ns_server
    • Security Level: Public
    • Labels:
    # Subject Project Status CR V
    For Gerrit Dashboard: &For+MB-8145=message:MB-8145

      Activity

      Hide
      alkondratenko Aleksey Kondratenko (Inactive) added a comment -

      Yes. Naturally we've secured API calls too.

      Show
      alkondratenko Aleksey Kondratenko (Inactive) added a comment - Yes. Naturally we've secured API calls too.
      Hide
      daschl Michael Nitschinger added a comment -

      I just tried the RO user and it looks good, but one thing I found:

      when logged in as RO and you click on documents, it shows the "Edit Document" button.. you cant modify it then, but its misleading.. maybe this can be renamed to "Show Document"? Or just hide the button since when you click on the key you can inspect it anyway.. just the "edit" is misleading when you actually can't edit.

      Show
      daschl Michael Nitschinger added a comment - I just tried the RO user and it looks good, but one thing I found: when logged in as RO and you click on documents, it shows the "Edit Document" button.. you cant modify it then, but its misleading.. maybe this can be renamed to "Show Document"? Or just hide the button since when you click on the key you can inspect it anyway.. just the "edit" is misleading when you actually can't edit.
      Hide
      daschl Michael Nitschinger added a comment -

      reopening because of ui enhancement.

      please determine if this is reasonable - thanks.

      Show
      daschl Michael Nitschinger added a comment - reopening because of ui enhancement. please determine if this is reasonable - thanks.
      Hide
      alkondratenko Aleksey Kondratenko (Inactive) added a comment -

      Michael, that thing was recently fixed as part of Author: Aliaksey Kandratsenka <alk@tut.by> 2013-08-16 23:05:47
      Committer: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com> 2013-08-17 03:27:33
      Parent: eec4087c95cd95bb9b7fe6f4dd36d67600358122 (MB-8855 Lower xdcrMaxConcurrentReps limit.)
      Child: 79bf28a9e13cc144f29e01367779f2583bbe1380 (MB-100 get rid of redundant rewrite_key_value_tuples function)
      Branches: b220, remotes/gerrit/2.2.0, remotes/gerrit/master, remotes/origin/2.2.0, remotes/origin/master, v2
      Follows: 2.2.0r
      Precedes:

      MB-8789: hide data & views access for read-only admin

      As per ticket, we only allow access to view definitions but neither to
      view data, nor to documents.

      Change-Id: Id07657e26553242017b1bf1b5a1a6269d1af7107
      Reviewed-on: http://review.couchbase.org/28313
      Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
      Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>

      Show
      alkondratenko Aleksey Kondratenko (Inactive) added a comment - Michael, that thing was recently fixed as part of Author: Aliaksey Kandratsenka <alk@tut.by> 2013-08-16 23:05:47 Committer: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com> 2013-08-17 03:27:33 Parent: eec4087c95cd95bb9b7fe6f4dd36d67600358122 ( MB-8855 Lower xdcrMaxConcurrentReps limit.) Child: 79bf28a9e13cc144f29e01367779f2583bbe1380 ( MB-100 get rid of redundant rewrite_key_value_tuples function) Branches: b220, remotes/gerrit/2.2.0, remotes/gerrit/master, remotes/origin/2.2.0, remotes/origin/master, v2 Follows: 2.2.0r Precedes: MB-8789 : hide data & views access for read-only admin As per ticket, we only allow access to view definitions but neither to view data, nor to documents. Change-Id: Id07657e26553242017b1bf1b5a1a6269d1af7107 Reviewed-on: http://review.couchbase.org/28313 Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com> Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
      Hide
      daschl Michael Nitschinger added a comment -

      woops, sorry! It didn't made it into my build here, need to upgrade I guess. thanks!

      Show
      daschl Michael Nitschinger added a comment - woops, sorry! It didn't made it into my build here, need to upgrade I guess. thanks!

        People

        • Assignee:
          iryna iryna
          Reporter:
          dipti Dipti Borkar
        • Votes:
          0 Vote for this issue
          Watchers:
          7 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: