Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-1276

Add extension method to configure MS Logging

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Do
    • Affects Version/s: None
    • Fix Version/s: 2.4.1
    • Component/s: None
    • Labels:
      None

      Attachments

      For Gerrit Dashboard: NCBC-1276
      # Subject Branch Project Status CR V

        Activity

        Hide
        mike.goldsmith Michael Goldsmith added a comment -

        After discussion with Brant and Jeff, we have decided that this extension method probably isn't required.

        What we have right now is good enough and the suggested extension method name "ConfigureCouchbase" that extends the ILoggerFactory interface is probably confusing as we're just taking a reference to it so we can create Logger instances instead of actually making changes to ILoggerFactory.

        We can reopen this ticket if we feel an extension method could add value.

        Show
        mike.goldsmith Michael Goldsmith added a comment - After discussion with Brant and Jeff, we have decided that this extension method probably isn't required. What we have right now is good enough and the suggested extension method name "ConfigureCouchbase" that extends the ILoggerFactory interface is probably confusing as we're just taking a reference to it so we can create Logger instances instead of actually making changes to ILoggerFactory. We can reopen this ticket if we feel an extension method could add value.

          People

          • Assignee:
            mike.goldsmith Michael Goldsmith
            Reporter:
            mike.goldsmith Michael Goldsmith
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes

                PagerDuty

                Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.