Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-1404

IClusterManager.CreateBucket is missing a proxyPort parameter

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 2.4.4
    • Fix Version/s: 2.4.5
    • Component/s: library
    • Labels:
      None

      Description

      I noticed that proxyPort was hard-coded to zero and breaks a call to create an ephemeral bucket; the parameter is completely missing from the method signature. Since this is a non-backwards compatible change, it will have to wait to a major.

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

            Hide
            mike.goldsmith Michael Goldsmith added a comment -

            Could we add an additional signature that has a port parameter with the implementation of the existing method passing through to the new one with a 0?

            Show
            mike.goldsmith Michael Goldsmith added a comment - Could we add an additional signature that has a port parameter with the implementation of the existing method passing through to the new one with a 0?
            Hide
            jmorris Jeff Morris added a comment -

            Yeah, i was debating just providing an additional overload, but had some reservations. Namely that were widening instead of fixing, but maybe that's just analysis paralysis. 

            Show
            jmorris Jeff Morris added a comment - Yeah, i was debating just providing an additional overload, but had some reservations. Namely that were widening instead of fixing, but maybe that's just analysis paralysis. 
            Hide
            jmorris Jeff Morris added a comment -

            Fixed here: NCBC-1345

            Show
            jmorris Jeff Morris added a comment - Fixed here:  NCBC-1345

              People

              • Assignee:
                jmorris Jeff Morris
                Reporter:
                jmorris Jeff Morris
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes

                    PagerDuty

                    Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.