Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-1405

SDK Enhanced Error Messages

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0
    • Component/s: None
    • Labels:

      Attachments

        Issue Links

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          mike.goldsmith Michael Goldsmith added a comment -

          Code is complete but moving to 2.5.0 release because it will change response messages which customers could rely on. This is because of an existing bug in the .NET client where the response body was always parsed as a string and returned as the response message.

          We are looking into getting this change tested by QE before 2.5.0.

          Show
          mike.goldsmith Michael Goldsmith added a comment - Code is complete but moving to 2.5.0 release because it will change response messages which customers could rely on. This is because of an existing bug in the .NET client where the response body was always parsed as a string and returned as the response message. We are looking into getting this change tested by QE before 2.5.0.
          Hide
          jmorris Jeff Morris added a comment - - edited

          It actually wasn't bug; the response body was only treated as a string when the response failed. In some cases the server would return a string error response, in other's it wouldn't. For the cases where its a valid string it made sense at the time to return it as the Message property - the message returned from the server in the case of an error. The body in all success cases is converted to the type defined in the flags - it is mapped to the Value property.

          Show
          jmorris Jeff Morris added a comment - - edited It actually wasn't bug; the response body was only treated as a string when the response failed. In some cases the server would return a string error response, in other's it wouldn't. For the cases where its a valid string it made sense at the time to return it as the Message property - the message returned from the server in the case of an error. The body in all success cases is converted to the type defined in the flags - it is mapped to the Value property.
          Hide
          mike.goldsmith Michael Goldsmith added a comment -

          Jeff Morris - I don't think I picked my words correctly. I meant it is now meant to be considered a bug according to the Enhanced Error Messages RFC where the response body is only meant to be read for failed operations if the the JSON bit is set. The server won't be using the JSON bit flag for older messages such as "TEMP_ERROR".

          Show
          mike.goldsmith Michael Goldsmith added a comment - Jeff Morris - I don't think I picked my words correctly. I meant it is now meant to be considered a bug according to the Enhanced Error Messages RFC where the response body is only meant to be read for failed operations if the the JSON bit is set. The server won't be using the JSON bit flag for older messages such as "TEMP_ERROR".
          Hide
          jmorris Jeff Morris added a comment -

          merged

          Show
          jmorris Jeff Morris added a comment - merged

            People

            • Assignee:
              mike.goldsmith Michael Goldsmith
              Reporter:
              tyler.mitchell Tyler Mitchell (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty

                  Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.