Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-1423

Document.Expiry description says it's in Milliseconds, should be seconds

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4.8
    • Component/s: None
    • Labels:
      None

      Attachments

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        jmorris Jeff Morris added a comment -

        Looking at the code, it appears it should be in milliseconds: https://github.com/couchbase/couchbase-net-client/blob/master/Src/Couchbase/Utils/TimeSpanExtensions.cs#L35

        The other overload for ToTtl that takes a TimeStamp, will return seconds, but the input is milliseconds. 

         

        Show
        jmorris Jeff Morris added a comment - Looking at the code, it appears it should be in milliseconds: https://github.com/couchbase/couchbase-net-client/blob/master/Src/Couchbase/Utils/TimeSpanExtensions.cs#L35 The other overload for ToTtl that takes a TimeStamp, will return seconds, but the input is milliseconds.   
        Hide
        jmorris Jeff Morris added a comment -

        Closing because CBSE that triggered it is closed.

        Show
        jmorris Jeff Morris added a comment - Closing because CBSE that triggered it is closed.
        Hide
        mike.goldsmith Michael Goldsmith added a comment -

        Jeff Morris shouldn't we still make the change to ensure the code documentation is accurate? It isn't as urgent without the CBSE but I think it's still worth doing.

        Show
        mike.goldsmith Michael Goldsmith added a comment - Jeff Morris shouldn't we still make the change to ensure the code documentation is accurate? It isn't as urgent without the CBSE but I think it's still worth doing.
        Hide
        jmorris Jeff Morris added a comment -

        Michael Goldsmith sure, the CBSE was closed so I assumed it was no longer an issue. Feel free to re-open!

        Show
        jmorris Jeff Morris added a comment - Michael Goldsmith sure, the CBSE was closed so I assumed it was no longer an issue. Feel free to re-open!
        Hide
        mike.goldsmith Michael Goldsmith added a comment -

        After further investigation, the Document.Expiry is described correctly, but I've added a commit to improve the TimeSpanExtensions.ToTtl(uint) method.

        Show
        mike.goldsmith Michael Goldsmith added a comment - After further investigation, the Document.Expiry is described correctly, but I've added a commit to improve the TimeSpanExtensions.ToTtl(uint) method.

          People

          • Assignee:
            mike.goldsmith Michael Goldsmith
            Reporter:
            mike.goldsmith Michael Goldsmith
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes

                PagerDuty

                Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.