Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-1423

Document.Expiry description says it's in Milliseconds, should be seconds

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.4.8
    • None
    • None

    Attachments

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

      Activity

        jmorris Jeff Morris added a comment -

        Looking at the code, it appears it should be in milliseconds: https://github.com/couchbase/couchbase-net-client/blob/master/Src/Couchbase/Utils/TimeSpanExtensions.cs#L35

        The other overload for ToTtl that takes a TimeStamp, will return seconds, but the input is milliseconds. 

         

        jmorris Jeff Morris added a comment - Looking at the code, it appears it should be in milliseconds: https://github.com/couchbase/couchbase-net-client/blob/master/Src/Couchbase/Utils/TimeSpanExtensions.cs#L35 The other overload for ToTtl that takes a TimeStamp, will return seconds, but the input is milliseconds.   
        jmorris Jeff Morris added a comment -

        Closing because CBSE that triggered it is closed.

        jmorris Jeff Morris added a comment - Closing because CBSE that triggered it is closed.

        Jeff Morris shouldn't we still make the change to ensure the code documentation is accurate? It isn't as urgent without the CBSE but I think it's still worth doing.

        mike.goldsmith Michael Goldsmith added a comment - Jeff Morris shouldn't we still make the change to ensure the code documentation is accurate? It isn't as urgent without the CBSE but I think it's still worth doing.
        jmorris Jeff Morris added a comment -

        Michael Goldsmith sure, the CBSE was closed so I assumed it was no longer an issue. Feel free to re-open!

        jmorris Jeff Morris added a comment - Michael Goldsmith sure, the CBSE was closed so I assumed it was no longer an issue. Feel free to re-open!

        After further investigation, the Document.Expiry is described correctly, but I've added a commit to improve the TimeSpanExtensions.ToTtl(uint) method.

        mike.goldsmith Michael Goldsmith added a comment - After further investigation, the Document.Expiry is described correctly, but I've added a commit to improve the TimeSpanExtensions.ToTtl(uint) method.

        People

          mike.goldsmith Michael Goldsmith
          mike.goldsmith Michael Goldsmith
          Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved:

            Gerrit Reviews

              There are no open Gerrit changes

              PagerDuty