Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-169

Compile time error in MemcachedTest project - VBucket constructor now takes 3 parameters

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      VBucket constructor now takes a third parameter - index.
      The class EnyimMemcached\MemcachedTest\VBucketTest.cs initializes VBucket with only two arguments, that leads to compile time error.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        saakshi.manocha Saakshi Manocha created issue -
        Hide
        saakshi.manocha Saakshi Manocha added a comment -
        • Forked the reporsitory from Couchbase\Enyimmemcached.
        • Added third parameter 'index' while initializing VBucket.
        • Committed and pushed changes into forked repository.
        • Send a pull request to master repository for review and merge.

        Change done:

        • File changed: EnyimMemcached\MemcachedTest\VBucketTest.cs
        • Replaced the following:

        private VBucket[] buckets = new[]
        {
        new VBucket(0, new[]

        {1, 2}),
        new VBucket(1, new[] {2, 0}),
        new VBucket(2, new[] {1, -1}),
        new VBucket(1, new[] {2, 0})
        };


        with

        private VBucket[] buckets = new[]
        {
        new VBucket(0, new[] {1, 2}

        , 0),
        new VBucket(1, new[]

        {2, 0}, 1),
        new VBucket(2, new[] {1, -1}, 2),
        new VBucket(1, new[] {2, 0}

        , 3)
        };

        Show
        saakshi.manocha Saakshi Manocha added a comment - Forked the reporsitory from Couchbase\Enyimmemcached. Added third parameter 'index' while initializing VBucket. Committed and pushed changes into forked repository. Send a pull request to master repository for review and merge. Change done: File changed: EnyimMemcached\MemcachedTest\VBucketTest.cs Replaced the following: private VBucket[] buckets = new[] { new VBucket(0, new[] {1, 2}), new VBucket(1, new[] {2, 0}), new VBucket(2, new[] {1, -1}), new VBucket(1, new[] {2, 0}) }; with private VBucket[] buckets = new[] { new VBucket(0, new[] {1, 2} , 0), new VBucket(1, new[] {2, 0}, 1), new VBucket(2, new[] {1, -1}, 2), new VBucket(1, new[] {2, 0} , 3) };
        saakshi.manocha Saakshi Manocha made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        saakshi.manocha Saakshi Manocha added a comment -

        change merged with master repository

        Show
        saakshi.manocha Saakshi Manocha added a comment - change merged with master repository
        saakshi.manocha Saakshi Manocha made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        brett19 Brett Lawson made changes -
        Workflow jira [ 22018 ] Couchbase SDK Workflow [ 43067 ]

          People

          • Assignee:
            saakshi.manocha Saakshi Manocha
            Reporter:
            saakshi.manocha Saakshi Manocha
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes