Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-1714

Review document expiry - seconds or milliseconds?

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Done
    • None
    • 2.6.1
    • None
    • None
    • 1

    Description

      Raised as part of this PR (it's now closed) but we should review to ensure our documentation / implementation is correct.

      https://github.com/couchbase/couchbase-net-client/pulls?q=is%3Apr+is%3Aclosed

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          jmorris Jeff Morris added a comment - - edited

          It's milliseconds; always has been afaik. Timespan overloaded were added to the non-Document (k/v style) methods to make it easier on developers. To be honest, the bug is that Document.Expiry is a uint and not a Timespan! However, it would be a major breaking change to change the Type, so we've just been living with it until Sdk 3.0. 

          Perhaps the confusion here is the difference between timeout and expiry?:

           

          jmorris Jeff Morris added a comment - - edited It's milliseconds ; always has been afaik. Timespan overloaded were added to the non-Document (k/v style) methods to make it easier on developers. To be honest, the bug is that Document.Expiry is a uint and not a Timespan! However, it would be a major breaking change to change the Type, so we've just been living with it until Sdk 3.0.  Perhaps the confusion here is the difference between timeout and expiry?: Timeout: the time given for an operation to successfully complete (regardless of result - success, not found, etc)  https://github.com/couchbase/couchbase-net-client/blob/master/Src/Couchbase/CouchbaseBucket.cs#L5170 Expiry: the lifetime of the document in couchbase  

          People

            mike.goldsmith Michael Goldsmith
            mike.goldsmith Michael Goldsmith
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty