Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-1770

Config requests are using ChildOf relationships on finished spans

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.2
    • Fix Version/s: 2.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Reported by user rwkarg on Gitter:

      Some feedback on OpenTracing behavior in the 2.6.2 client: We have ASP.NET services that have a span around service bootstrapping (including the Couchbase client). That span gets finished, but any async work started in that span (including the periodic polling of the Config operation) gets added to that finished, initial span.
      *initial trace
      This results in a single trace that is forever getting Config operations added to it. It ultimately stems from the behavior of StartActive that will add a ChildOf relationship to an existing ActiveSpan even if that span has been finished (I don't know if that is considered correct or incorrect OpenTracing behavior)
      To address this in our own code, we create a span around execution of periodic tasks that IgnoreActiveSpan since we know that this is triggered from a timer, not as the child of some higher level request processing.
      Would that be an approach that could get applied to the periodic Config operations performed by the client?
      

      Spans should not use the ChildOf relationship if the ActiveSpan has finished, although ScopeManager.ActiveSpan should not reference a Span that has finished.

        Attachments

        For Gerrit Dashboard: NCBC-1770
        # Subject Branch Project Status CR V

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              mike.goldsmith Michael Goldsmith
              Reporter:
              mike.goldsmith Michael Goldsmith
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty

                  Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.